Baseflow / octo_image

A multifunctional Flutter image widget
https://baseflow.com/
MIT License
156 stars 23 forks source link

fix(issue-34): dispose child when duration is zero #35

Closed AshishSingh2001 closed 1 month ago

AshishSingh2001 commented 2 months ago

:sparkles: fix issue #34

:arrow_heading_down: What is the current behavior?

The child is not getting disposed due to animation controller not giving callbacks when the duration is zero

:new: What is the new behavior (if this is a feature change)?

set the hide widget to true explicity when the direction is reverse and duration is zero

:boom: Does this PR introduce a breaking change?

NO

:bug: Recommendations for testing

:memo: Links to relevant issues/docs

34

https://github.com/Baseflow/flutter_cached_network_image/issues/942

:thinking: Checklist before submitting

AshishSingh2001 commented 2 months ago

@renefloor can you help review this