search

Basel-525k / geofence_foreground_service

Apache License 2.0
6 stars 5 forks source link

Add support for Android setNotificationResponsiveness #9

Closed orkun1675 closed 2 months ago

orkun1675 commented 2 months ago

Fixes https://github.com/Basel-525k/geofence_foreground_service/issues/7.

I wasn't sure how the Constants.swift file interacts with private enum CodingKeys; could you check if I got that part correct please?

Basel-525k commented 2 months ago

Thanks for the PR, the code looks clean and the changes are well written.

Above is my only comment of the PR, other than that all looks good

Thanks again 🙏

orkun1675 commented 2 months ago

I've made the default value of this new field null so that we are future-proofing incase Android decides to change the default value (from zero to something else). I've also added explicit buttons to the example app to exercise cases of using this field vs. not. And these are WAI in an emulator evironment.