Entity inconsistencies

[budjmt]

I'll be crossing off ones I do locally as I go, if anyone else is contributing, notify here of any progress

Enemies:

• Super pooters are white instead of pink
• Flaming gapers are named "sleepy gaper" and have the wrong sprite
• Drowned Hives have a recolor instead of their actual sprite
• Mr maw/red maw and swinger have "body" in their name despite spawning the real deal
• There's a second pooter(?) for some reason (to be looked into in game later) This is apparently a pooter variant that does not shoot. It was already in the unused section, but was still grouped in the palette incorrectly.
• Some sprites have padding issues that make them smaller than similar sprites in the selector
  • Crispy and flaming hopper (may also be a fire issue) (also now flaming gapers)
  • Blubber and half sack
  • Lump and Tar Boy they are just different sizes
  • Ticking spider vs lvl 2 spider (lvl 2 spider uses a 4px taller frame)
  • Rag man's ragling
  • Brim grimace up and down
  • Evil twin
  • several of the chargers
  • heart
  • black maw
  • begotten (also made homunculus consistent)
• Mushroom is grouped with hosts, not sure if that's still desirable since they're not host replacements in the same way anymore
• Stone eye is grouped with organs instead of as a stage hazard or with wall huggers they're now with grimaces
• Nerve ending two's sprite is a recolor, which makes it very hard to differentiate in the selector, and presumably in editor for colorblind people
• Black Globin's head is grouped in Other instead of gapers?
• Ragling's name is two words instead of one
• Baby long leg's names or sprites seem switched? names were correct, but because of sizing the baby sprite was larger than the adult
• Swarm's icon should [in my opinion] be a swarm and not a single fly since each one spawns a swarm
• Guts, scarred guts, and wall hugger's variant 0 is actually a random direction. Variant 4 is the correct one. also enhanced icons
• Big spiders should be centered better. TODO investigate other entities by placing them in the editor at least once
• Ring flies should have a better behavior indicator in icon, maybe a ring around it
• pacer body frames are inconsistent

Bosses:

• larry and hollow's sprites are their bodies instead of their head
• widow, wretched, big horn, mama gurdy are a bit small in the palette, this may not be fixable
• the gurgling sprite is very pixelated not really fixable with how icon sizing works right now
• angels don't have their normal names
• headless horseman -> headless horseman body
• Add the different sizes of envy/super envy super envy is bugged and will spawn with envy's sprites until split, so I didn't include him. Also updated body sprites
• turdlings have no legs
• super lust has the stupid transparent eye thing that was fixed in boosters

Other:

• fire grids are not marked different from fire place entities. Base game uses the grid, booster rooms use the entity
• active bomb picked the ugliest color possible
• padding on pitfalls could be adjusted to level them with the hush pitfall
• angel/devil statues are misaligned they also had the wrong sprite!
• iamerror is tiny in pallete
• scared heart has hair(?) on it
• charged key could use a different color for the charge that's easier to see
• key ring is bigger than the other keys I adjusted all pickups to be the same elevation and ~the same size per class
• blank and black rune are larger than the other runes several runes also had the wrong basic appearance
• tnt has too much padding at the bottom fixed it and basically every other grid
• keeper sprites/names should be switched from shop/secret room to sitting/hanging
• Troll bombs and mega troll bombs in the palette are using the bomb entity id instead of the pickup one, which is actually seen in rooms. Fixed and left the other ones in, but out of the palette
• "Beta" pressure plates are actually room clear plates and should be back in the palette
• Corn mines' xml entry is wrong and it should be moved to poop instead of other the icon file also had the wrong name
• Trap doors and dirt patches are slightly taller than a grid space the icons were fine, they just needed a slight offset
• Carpet/dice floors need offsets
• in crawlspaces, "random decorations" actually comprise the ladders and empty space and should be displayed that way for coherency worth noting that the icons actually had subtype and variant swapped, I also made blocks work
• give UG his own section with his coins also separated story bosses from recurring bosses
• Decoy bombs are displayed as bob's rotten head bombs
• tears... moved to unused, chaos card moved to other
• many grid ents have extra padding
• several cards have incorrect filenames as of ab+'s insertion of the ace cards

Other proposed changes

• the broken category in stage is useless and should be removed moved to the unused section
• a lot of enemy groups are outdated and/or illogical and should be reorganized; general fix idea is to sort roughly by heavily associated chapter or broader categories
• sort bosses within chapters roughly by expansion

Additional

• more effects, particularly hot bomb fires (1000.51.1) and creep (1000.22+.0)
• missing holy poop
• add old missing entities properly, war no horse, death horse, death no horse, satan phase 2, gemini baby, steven baby
• change the pushable poop icon to be distinct decided just to hide it from the palette
• swap pressure plate icon with greed plate icon
• make greed icon more distinct
• recolor retracting spikes to make them more visible

[piber20]

Holy Poop appears to be missing.

Some effects might be useful, like the hot bomb fires (variant 51, subtype 1 can damage both enemies and players if i remember right), creep, etc

[budjmt]

https://github.com/Tempus/Basement-Renovator/pull/171 Still in progress, but it's a start. Some of the more egregious things addressed.

[budjmt]

https://github.com/Tempus/Basement-Renovator/pull/174 some more work

[Erfly]

Pushable poops should have a seperate icon to be distinguished from normal poops, stops them being accidentally placed.

[budjmt]

https://github.com/Tempus/Basement-Renovator/pull/186 even moooore work

[piber20]

Greed Plate is using room clear button's icon, and Pressure Plate (room clear) is using default pressure plate's icon

[budjmt]

https://github.com/Tempus/Basement-Renovator/commit/4f0609798591c233c1db18eea6b27443381b700d mooooore work