search

Basement-Renovator / basement-renovator

A room editor for Binding of Isaac Rebirth
Other
64 stars 28 forks source link

Remove Sprite Smoothing #277

Closed kittenchilly closed 2 years ago

kittenchilly commented 2 years ago

I don't know why this was added in the first place. Removing it better reflects how stuff actually looks in-game, as well as just looking better overall.

budjmt commented 2 years ago

I tested this change and compared with main. What I observe is that at certain resolutions, this does look better. However, because of how BR's scaling works however we render sprites has to look decent at a variety of weird scales. I think that on average, the current look is better.

If you do find an alternative collection of settings that looks good (and not bit-crunchy) at many different scales, I'm certainly open to it. But supporting all of these scale modes is [currently] important.

Zamiell commented 2 years ago

also if you are going to do a pr make sure it passes the linter first

Zamiell commented 2 years ago

i'll close this since chil isn't responding