search

Basement-Renovator / basement-renovator

A room editor for Binding of Isaac Rebirth
Other
64 stars 28 forks source link

Allow for creating modded room subtypes #313

Open thicco-catto opened 5 months ago

thicco-catto commented 5 months ago

Before, creating a RoomTypesMod.xml only allowed you to completely replace the room gfx. Now it compares the subtype of the new room gfx entry with the previous ones to check if it should replace it or add the new room gfx entry. This allows people to add variants of existing room types by only changing the subtype.

budjmt commented 5 months ago

Can you paste an example XML snippet demonstrating a usecase that wasn't possible before but is with this change?

thicco-catto commented 5 months ago

This XML makes it so setting a bedroom's subtype to 30 changes the backdrop

<data>
    <room Name="Isaac's Room">
        <Gfx BGPrefix="Backgrounds/MyCustomBackdrop" Subtype="30"/>
    </room>
</data>
budjmt commented 5 months ago

Are you on discord? If so can you join the Basement Renovator discord: https://discord.gg/h6aaMTx9 My suspicion is that this should already work based on Revelations' custom roomtypes xml (though that is based on name not subtype)

Zamiell commented 1 month ago

@thicco-catto did you talk to bud about this on discord?