Bash-it / bash-it

A community Bash framework.
MIT License
14.14k stars 2.29k forks source link

Update for liquidprompt theme v2.0 support #2203

Open cdoenges opened 1 year ago

cdoenges commented 1 year ago

When using the theme liquidprompt v2.0 or later with bash-it, bash issues an error message when the prompt is displayed with the current working directory in a git repository that is not in detached head state.

Description

In v2.0 (released Feb 5, 2021) of liquidprompt, the function _lp_escape() was renamed to __lp_escape(). Therefore, calling the function by the old name results in an error message from bash. By using the new name, the problem goes away.

The shim used by bash-it still uses the old name.

Motivation and Context

The annoying error message goes away with this change.

How Has This Been Tested?

Change made. Issued bash-it reload. Error message no longer appears.

Screenshots (if appropriate):

Types of changes

Checklist:

davidpfarrell commented 1 year ago

Greetings @cdoenges !

I'm guessing you didn't see #2175 which is also trying to fix this.

Maybe you can collab with @DarrenBishop to review each other's changes and decide on the best way forward.