search

Bash-it / bash-it

A community Bash framework.
MIT License
14.3k stars 2.29k forks source link

fix: lint :green_heart: #2213

Closed robertoschiavone closed 1 year ago

robertoschiavone commented 1 year ago

Description

This commit bumps go version to 1.21.0 and changes go get to go install.

Motivation and Context

Current workflow for PRs is broken because the tool that is invoked to format the code, shfmt, requires go >= 1.19.

How Has This Been Tested?

Workflow was launched again after fix and it doesn't fail anymore.

Types of changes

Checklist:

bittner commented 1 year ago

Please merge this PR! - All new PRs are failing without this change, currently.

hyperupcall commented 1 year ago

It looks like #2224 that I just made is similar - but I have also updated the GitHub actions that we use

davidpfarrell commented 1 year ago

For KISS reasons I think we should go with this one, but thank you all for taking the time to get this fixed !

cc: @robertoschiavone , @hyperupcall , @bittner

hyperupcall commented 1 year ago

Sounds good - perhaps I should update mine to only make only the Actions upgrades once this is merged

davidpfarrell commented 1 year ago

Sounds good - perhaps I should update mine to only make only the Actions upgrades once this is merged

Yeah we can do that ... One Q on it (which I should have posted over there on it): Are the quotes needed? Although technically more correct, having some quoted and some non-quoted values feels less clean than current .... I would say leave unquoted unless needed

hyperupcall commented 1 year ago

Yeah quotes in YAML aren't needed unless they're actually needed. I've heard too many near-death experiences from YAML that I have a habit of quoting everything I touch. But no worries I'll make the changes without quotes this time around (unless you want everything to be quoted, which seems unlikely)