Bashamega / TrendTrack

TrendTrack is a platform that keeps you updated on the latest trending repositories across GitHub.
https://trendtrack.vercel.app
MIT License
18 stars 14 forks source link

[FEATURE] Add the ability to hide repositories you reviewed #38

Closed wiki-me closed 1 month ago

wiki-me commented 2 months ago

Is this a unique feature?

Is your feature request related to a problem/unavailable functionality? Please describe.

When looking at the list of trending repositories , the user might have to repeatedly continue scroll over repositories he already reviewed.

Proposed Solution

Add a button to hide repositories, so they won't be shown again, possibly with a page that shows the hidden repositories (in case you accidently pressed the button)

Do you want to work on this issue?

No

Bashamega commented 2 months ago

Great feature

kvtemadden commented 1 month ago

Hey @Bashamega, am I alright to pick this up?

Bashamega commented 1 month ago

Hey @Bashamega, am I alright to pick this up?

Of course

wiki-me commented 1 month ago

Thanks for adding this feature (its a significant upgrade over github IMO), but clicking on "viewed repos" after viewing repos and even hiding them after clicking "hide viewed" shows nothing ("no data!").

Bashamega commented 1 month ago

Thanks for adding this feature (its a significant upgrade over github IMO), but clicking on "viewed repos" after viewing repos and even hiding them after clicking "hide viewed" shows nothing ("no data!").

Thank you for reporting this issue. @kvtemadden Can you fix this issue in another pr? Thanks

kvtemadden commented 1 month ago

Hey @wiki-me, could you send a screen recording? I've tried to repro but I haven't been able to.

Here's what happens my end (this is at TrendTrack)

Screen Recording 2024-10-07 at 12 12 14

wiki-me commented 1 month ago

simplescreenrecorder-2024-10-07_19 24 38

The web console messages also seems relevant:

console-export-2024-10-7_19-28-43.txt

wiki-me commented 1 month ago

It will also be good to remember the setting to "hide viewed", so if i return to the page later the viewed repositories will still be hided

kvtemadden commented 1 month ago

Cheers for sharing that. Are you using Edge as a browser?

remember the setting to "hide viewed"

I'll also add that ability in too.


Just looked into the error you sent, that's actually not related to this but instead related to the will-change property on the repo display elements.

Possibly worth opening another issue to look into this @Bashamega?

I'll fix the localStorage issue in the meantime.

Bashamega commented 1 month ago

Sure that would be great. Thank you @kvtemadden

wiki-me commented 1 month ago

Cheers for sharing that. Are you using Edge as a browser?

its on debian 12 , both on firefox ESR - "128.3.0esr (64-bit)" and on chromium - "Version 129.0.6668.89 (Official Build)".

Bashamega commented 1 month ago

@wiki-me Can you check #68 ?