Tweak to hide viewed - Githubissues

Bashamega / TrendTrack

TrendTrack is a platform that keeps you updated on the latest trending repositories across GitHub.

https://trendtrack.vercel.app

MIT License

18 stars 14 forks source link

Tweak to hide viewed #68

Closed kvtemadden closed 1 month ago

kvtemadden commented 1 month ago

Description

Amended due to issue handling date on different browsers, which had a side effect of not showing "viewed repos" on the /repos/viewed page. Also added the ability to "remember" whether a user had hidden the repos.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
trendtrack	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 10, 2024 8:48am

Bashamega commented 1 month ago

Thanks for fixing

kvtemadden commented 1 month ago

Hey @Bashamega, just went back over this and noticed that the "remember hide" isn't working, so I've just pushed a fix for that.

Bashamega commented 1 month ago

Hey @Bashamega, just went back over this and noticed that the "remember hide" isn't working, so I've just pushed a fix for that.

No problem, I just ping @wiki-me to review it. It is working for me

wiki-me commented 1 month ago

"viewed repos" works, but it does not remember after i click on hide (after refresh it still shows the viewed repos).

kvtemadden commented 1 month ago

"viewed repos" works, but it does not remember after i click on hide (after refresh it still shows the viewed repos).

The tweak I made this morning was to fix that, not sure if it needs pushing since the update.

Bashamega commented 1 month ago

I am going to push to prod

wiki-me commented 1 month ago

Ok , i switched to the relevant branch , sorry. There was a error message locally but now when it is in production it seems to work well.