Closed Sparker0i closed 7 years ago
Well for now it shows the current app logo (which is a round icon) , along with the spinner, it spins for 3s, and then load the MainActivity
@Sparker0i code looks okay to me. Since travis is not added to the repo, the screenshot is just to see whether app is building or not. I will merge after the screenshot. Thanks 👍
@Sparker0i can you change the commit message and provide a reference of issue in that PR commit message it will be easy to see PR request from issue section
Sure. Could you please guide me to how to reference that issue in a PR. I'm pretty new to contributing to other sources, that's why I asked.
And what would you like to have the commit message as?
On 11-Oct-2017 2:29 AM, "Vaibhav Rai" notifications@github.com wrote:
@Sparker0i https://github.com/sparker0i can you change the commit message and provide a reference of issue in that PR it will be easy to see PR request from issue section
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Bashmug/HappyPanda/pull/14#issuecomment-335606121, or mute the thread https://github.com/notifications/unsubscribe-auth/AOSdWMDj41IZNil1rqXyAwf76qF4JzJBks5sq9qqgaJpZM4Px0Da .
@Sparker0i go through https://help.github.com/articles/closing-issues-using-keywords/ and just add Closes #issue_no in your commit message,it will get referenced automatically
@akarshan96 here are the screenshots. the icon is kinda enlarged for now, we can fix that later
@Sparker0i Looks good 👍. Yeah, we can change image later.
Thanks :+1:
@Sparker0i Can you share the screenshot and apk. Cheers.