BasicAirData / AirDataComputer

Air Data Computer
https://www.basicairdata.eu/projects/airdatacomputer/
Other
32 stars 23 forks source link

Review the File dump method #57

Closed GrazianoCapelli closed 6 years ago

GrazianoCapelli commented 6 years ago

The Dump method (from SD to the serial interfaces) now have some problems:

JLJu commented 6 years ago

Current file download is bulky but easy to implement Teensy side and Android/BT/PC side. Unfortunately, to block the transfer you should cut the power to the ADC.

Move to a standard protocol for file transfer would allow us to use standard serial terminal software, that can be comfortable and also allow automatic scripts to be executed over the serial connection. Zmodem implementation seems to be available for Teensy https://forum.pjrc.com/threads/26646-Zmodem-transfer-from-Teensy-to-PC https://forum.arduino.cc/index.php?topic=382044.0

GrazianoCapelli commented 6 years ago

For now I implemented an easy way to abort the dump (commit 7319735).

Now it is possible to end the dump anytime, by sending another command from the same serial interface. The dump will send the $EOF sentence and will terminate. The new command sent will be processed as usual.

It is possible to know if the file is fully downloaded, comparing the remote and the local size. I took a look to your link and, basing on that code, I choose to add a periodic flush() during the dump process.

The dump method now seems to be raw but fully functional. To be deeply tested!

Let's take our time to think (and in case implement) the Zmodem interface!

JLJu commented 6 years ago

Way to go!