search

BasicAirData / GPSLogger

A GPS logger for Android mobile devices
http://www.basicairdata.eu/projects/android/android-gps-logger/
GNU General Public License v3.0
403 stars 126 forks source link

Set the Navigation Bar Color according with the bottom bar #225

Open GrazianoCapelli opened 2 months ago

GrazianoCapelli commented 2 months ago

We should set the Navigation Bar Colour to match the colour of the bottom bar on the main activity. We should also check that the icons of the navigation bar button are visible (white on black, and black on white). Here below how we would like to colour the bottom navigation bar for Dark / Light theme:

Desired

Please implement it only for GPSActivity, because it is the only UI that benefits of the colour change and it is less code invasive.

Sauhard74 commented 1 month ago

can i work on this issue?

GrazianoCapelli commented 1 month ago

Sure, I assign the issue to you.

If you take care of more than 1 issue, please use a branch for each issue. The CONTRIBUTING.md file shows how we are used to name and use branches.

Thanks in advance for any contribution!

Sauhard74 commented 1 month ago

Sure

VasireddyGanesh commented 1 month ago

I couldn't find an Android API to change the navigation bar color for devices running Android API versions below 21. Should we still support changing the navigation bar color for devices with Android API versions below 21?

GrazianoCapelli commented 1 month ago

Android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLYPOP (API 21) would be perfect, we cover the 98% of devices. For older versions we can leave the colors as are.

VasireddyGanesh commented 1 month ago

@GrazianoCapelli can you please answer to below 2 questions

  1. Should we change the navigation bar color and icons color only in MainActivity, or should we apply it to all activities, such as Settings and About activities as well?

  2. Although we can change the navigation bar color starting from API version 21, we can only change the navigation bar icon colors starting from API version 26. Therefore, only for devices with API version 26 and above, I will change both the navigation bar color and the icon colors. For devices with lower API versions, I will leave the colors as they are, which is a black navigation bar with gray icons. Is this fine ?

GrazianoCapelli commented 1 month ago

Should we change the navigation bar color and icons color only in MainActivity, or should we apply it to all activities, such as Settings and About activities as well?

I think you could change the colour for all the activities. Do you think that we have problems somewhere?

Although we can change the navigation bar color starting from API version 21, we can only change the navigation bar icon colors starting from API version 26. Therefore, only for devices with API version 26 and above, I will change both the navigation bar color and the icon colors. For devices with lower API versions, I will leave the colors as they are, which is a black navigation bar with gray icons. Is this fine ?

Yes it's fine, thanks.

VasireddyGanesh commented 1 month ago

I think you could change the colour for all the activities. Do you think that we have problems somewhere?

There are no issues, @GrazianoCapelli . I asked about it just to understand the requirements.

VasireddyGanesh commented 1 month ago

I have fixed this issue but couldn't able to push my local branch to the remote github repo. Iam getting permission denied error. I have already configured ssh key based authentication in my laptop. can you please help me with this @GrazianoCapelli

GrazianoCapelli commented 1 month ago

I have fixed this issue but couldn't able to push my local branch to the remote github repo. Iam getting permission denied error. I have already configured ssh key based authentication in my laptop. can you please help me with this

In the Network Graph of GPS Logger your forked repo is not present. If you want to pull a request you should start from a forked repo of GPS Logger.

VasireddyGanesh commented 1 month ago

In the Network Graph of GPS Logger your forked repo is not present. If you want to pull a request you should start from a forked repo of GPS Logger.

Thank you @GrazianoCapelli , now i could able to raise a PR. Please review it and let me know if any changes required

VasireddyGanesh commented 1 month ago

@GrazianoCapelli I have made changes according to your previous review comments. I hope this new PR addresses those issues. Please let me know if any further changes are required.

maiHydrogen commented 1 month ago

is this issue still open ? actually i'm new to open source so i's taking me some time to familiarize with standard norms. if it's open can i work on this?