search

BasicProbability / LectureNotes

Lecture Notes (with exercises) for Basic Probability course at University of Amsterdam
17 stars 12 forks source link

Please accept me now! #16

Closed philschulz closed 9 years ago

cschaffner commented 9 years ago

maybe the bars in the bar-plot could be a thicker? so that the thin red line does not cover them entirely?

cschaffner commented 9 years ago

Thanks a lot for all the work, @philschulz . It looks pretty good to me on first sight!

philschulz commented 9 years ago

Hey Christian,

I will incorporate your comments and try to resolve the merge conflict either today or tomorrow. Making the bars in the plot bigger is no problem, I will just adjust the R script.

Have a nice weekend!

cschaffner commented 9 years ago

@philschulz , I have some more changes that you can find in https://github.com/BasicProbability/LectureNotes/pull/15 I guess you will have to merge them manually again...

philschulz commented 9 years ago

Hey Christian,

I incorporated your proposed changes and removed the merge conflicts. The pull request can now be accepted.

Here is what remains to do:

1) I have made a couple of inline comments myself, mostly in response to yours. If you regard the problems as resolved, just erase the comments.

2) Make the usual chapter3.tex and chapter3_forInclude.tex partition. This should only be done AFTER this request has been accepted.

3) Compile the pdfs after this request has been accepted.

4) Update script and website.

One last remark: Merge conflicts seem to ensue whenever we update the pdfs (that's also why the pdfs in this pull request have not been updated). For the future we should probably only update the remote pdfs once we have a final version.