search

BasileiosKal / blind-bbs-signatures

Other
1 stars 2 forks source link

Fix typo and messages.json fixture #7

Closed AlbertoSvg closed 6 months ago

AlbertoSvg commented 6 months ago

Hello, I fixed a typo in the deserialization section of BlindProofGen, and the messages.json fixture has been updated with the correct data, ensuring coherence with the data in the other fixtures.

I believe there is still an issue with the proof008.json fixture. In my implementation, it's the only test vector that fails. Upon investigation, I discovered that it fails due to incorrect computation of the random scalars. Thefixture refers to the scalars generated with a value of U = 6 (random_scalars = calculate_random_scalars(5+U)) in CoreProofGen, but I believe it should be 5 instead of 6.

BasileiosKal commented 6 months ago

Thank you for finding this issue! For proof008 will check and fix it in a subsequent PR. Appreciate the help 🙏