search

BasioMeusPuga / Lector

Qt based ebook reader
GNU General Public License v3.0
1.52k stars 209 forks source link

"scalable" icons directory should only be used for scalable (vector) image formats #138

Open audreytoskin opened 4 years ago

audreytoskin commented 4 years ago

A minor issue, but I think this mismatch might be affecting how Lector appears in the "app stores" for the distros where it's been packaged...

By default on Linux, Lector installs its Lector.png icon under /usr/share/icons/hicolor/scalable/apps/. However, That "scalable" subdirectory is supposed to only be used for scalable (vector) image formats -- on my system, basically every other image in that directory is an SVG, not a PNG.

Since, Lector.png is a 512×512-pixel raster image, I think it should get installed to /usr/share/icons/hicolor/512x512/apps/ instead. (The downside here being if you replaced it with a larger image, you would need to move it to the the matching directory.)

Or, you could use the scalable directory if you had an SVG version of the Lector icon.

audreytoskin commented 4 years ago

...Or maybe it would be better to use ./lector/resources/raw/logo/icon.svg instead? It's a nicer-looking image, and is also newer by about a year, so I suddenly wonder if ./lector/resources/raw/Lector.png is just leftovers from an older design that otherwise isn't used anymore.