search

BasioMeusPuga / Lector

Qt based ebook reader
GNU General Public License v3.0
1.51k stars 208 forks source link

Flexible line spacing? #64

Open nickcorona opened 6 years ago

nickcorona commented 6 years ago

Currently, if you set line padding to a certain value, it maintains that same value when you make the window full-screen or not. So, line spacing changes depending on the size of the window. This isn't ideal; line spacing should remain constant, and line padding should change depending on the size of the window.

BasioMeusPuga commented 6 years ago

You're correct. I'll fix this in the next commit.

elisamalzoni commented 4 years ago

Was this resolved? I found this while testing:

lector-line-spacing-test

nickcorona commented 4 years ago

No

On Thu, 24 Oct 2019 at 08:17, Elisa Malzoni notifications@github.com wrote:

Was this resolved?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/BasioMeusPuga/Lector/issues/64?email_source=notifications&email_token=ABZEXFLGRQNXYQHOMKJZDNTQQGG4NA5CNFSM4FDAKNF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECE2BFI#issuecomment-545890453, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZEXFNUTEBOYMAIZRBMJ53QQGG4NANCNFSM4FDAKNFQ .

elisamalzoni commented 4 years ago

Ok, I'll be working on this.

BasioMeusPuga commented 4 years ago

Hello. I'm afraid I've been on a break from development due to unavoidable IRL circumstances. That said, please help me understand this better. In that gif both padding and line spacing seems fixed to me - which is intended behavior. Am I correct in assuming you'd like the padding to change so that the text occupies the same area regardless of window size?

nickcorona commented 4 years ago

Hello. I'm afraid I've been on a break from development due to unavoidable IRL circumstances. That said, please help me understand this better. In that gif both padding and line spacing seems fixed to me - which is intended behavior. Am I correct in assuming you'd like the padding to change so that the text occupies the same area regardless of window size?

That's correct. If the goal is to set line spacing to a constant value it should be maintained when you expand the window.

elisamalzoni commented 4 years ago

I am trying to implement the padding relative to the window size, I'll make a PR when I am done.

elisamalzoni commented 4 years ago

I think i got it! You wanted something like this?

padding_ot

Now the padding is relative to the window width.

elisamalzoni commented 4 years ago

I've done the PR. Was that it? @nickcorona @BasioMeusPuga