search

BasioMeusPuga / Lector

Qt based ebook reader
GNU General Public License v3.0
1.51k stars 208 forks source link

Shift to PySide2 ? #86

Closed khaveesh closed 5 years ago

khaveesh commented 5 years ago

Now that PySide2 has been officially accepted as the standard python-qt binding, maybe shift Lector from PyQt5 to PySide2. They are mostly compatible with each other AFAIK.

BasioMeusPuga commented 5 years ago

It doesn't seem as simple as substituting PyQt5 for PySide2 in the imports. I'm getting segfaults here. And from my understanding, there's very little advantage. Perhaps if PyQt5 stops being maintained, or starts giving me trouble, I'll think about it.