BasisResearch / chirho

An experimental language for causal reasoning

https://basisresearch.github.io/chirho/getting_started.html

Apache License 2.0

164 stars 10 forks source link

Fix tutorial to pass notebook CI tests #539

Closed SamWitty closed 2 months ago

SamWitty commented 2 months ago

528 changed the default name for fresh `split` operations from `intervened` to `__fresh_split__`. It appears that the CI for this PR was run before #533 was merged in, causing the CI to look like it was passing when it actually wasn't. See https://github.com/BasisResearch/chirho/actions/runs/8834817360/job/24259115895 for the error this causes.

This small PR changes any use of intervened with __fresh_split__ in the tutorial notebook, addressing the notebook CI failure.

Edit: This PR now changes TwinWorldCounterfactual to MultiWorldCounterfactual instead.

eb8680 commented 2 months ago

Instead of switching to the new correct default name under TwinWorldCounterfactual, can you change the tutorial to use MultiWorldCounterfactual so that the default name never appears in the first place? I think that would be less confusing.