allow for no outcome and null outcome weight

BasisResearch / cities

Home of Basis development for the 2023 TOP Sprint

MIT License

6 stars 0 forks source link

allow for no outcome and null outcome weight #49

Closed rfl-urbaniak closed 11 months ago

rfl-urbaniak commented 11 months ago

This PR resolves #47 .

The user can now instantiate FIPS queries without passing any outcome_var. They can also pass outcome_var, but exclude it from similarity weighting by giving it weight = 0.

See the first few cells of `similarity_demo.ipynb' for examples.

riadas commented 11 months ago

Got around this by using the "pass an outcome variable but then give it zero weight" technique, but ran into this bug while integrating with cities-app:

See https://github.com/BasisResearch/cities/issues/54.