BasisResearch / cities

Home of Basis development for the 2023 TOP Sprint
MIT License
6 stars 0 forks source link

adding basic variables at MSA level #92

Closed Niklewa closed 6 months ago

Niklewa commented 6 months ago
  • refactor save_file to avoid redundancies

    • make sure you test the new cleanup pipeline also for the county level and add a test that does so automatically

    • revise the structure of the data_gude (walkability/road density should be in transportation)

    • add TOC to the data guide as it is growing a bit large

I have implemented all the corrections. The tests have been created in a separate PR.

rfl-urbaniak commented 6 months ago

Also, please make sure that all variables that list_avaiable_features spits out are accounted for. :)

Niklewa commented 6 months ago

general data rules is now a supersection of everything in the data guide as far as the TOC is involved, make sure it's on the same level as the other ones. Also, I'm pretty sure we have more outcome variables, something is off. basically, any variable that comes as a time series is an outcome variable if it's not an intervention variable. Can you fix the categorization in the TOC?

Done

rfl-urbaniak commented 6 months ago

Screenshot from 2024-01-11 15-24-41

Niklewa commented 6 months ago

fails make test fails make lint

Made adjustments, now everything works.