search

BasisResearch / collab-creatures

Analyzing animal collaboration with Bayesian and causal inference.
4 stars 1 forks source link

Elm locust notebook #68

Closed emackev closed 5 months ago

emackev commented 6 months ago

Adding documentation to locust-approximate-pipeline.ipynb

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] commented 6 months ago

View / edit / reply to this conversation on ReviewNB

rfl-urbaniak commented on 2024-03-13T14:42:03Z ----------------------------------------------------------------

I think it would be useful to refer back to the rhf notebook for more background and simpler examples, could you please add a passage to this effect?


emackev commented on 2024-03-16T11:32:50Z ----------------------------------------------------------------

yup

review-notebook-app[bot] commented 6 months ago

View / edit / reply to this conversation on ReviewNB

rfl-urbaniak commented on 2024-03-13T14:42:04Z ----------------------------------------------------------------

I think here some explanation of what the communicate score is and how it is computed would be useful. Feel free to give it a shot, and I will revise/complete afterwards.


emackev commented on 2024-03-16T11:47:52Z ----------------------------------------------------------------

Added some explanation. Please verify that it's accurate, including the part about plotting (For ease of plotting, the communicate trace is only shown a a random subset of locations. -- consider adding what percentage is plotted? )

rfl-urbaniak commented on 2024-04-30T15:33:52Z ----------------------------------------------------------------

So the sub-sampling there takes place prior to predictor derivation, added an explanation earlier, and removed the one about plotting.

review-notebook-app[bot] commented 6 months ago

View / edit / reply to this conversation on ReviewNB

rfl-urbaniak commented on 2024-03-13T14:42:05Z ----------------------------------------------------------------

Line #1.    # plot the posterior distribution of the coefficients


emackev commented 6 months ago

yup

View entire conversation on ReviewNB

emackev commented 6 months ago

Added some explanation. Please verify that it's accurate, including the part about plotting (For ease of plotting, the communicate trace is only shown a a random subset of locations. -- consider adding what percentage is plotted? )

View entire conversation on ReviewNB

rfl-urbaniak commented 5 months ago

So the sub-sampling there takes place prior to predictor derivation, added an explanation earlier, and removed the one about plotting.

View entire conversation on ReviewNB

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.