search

BasisResearch / collab-creatures

Analyzing animal collaboration with Bayesian and causal inference.
4 stars 1 forks source link

Import fish data for velocity calculations #80

Closed PalkaPuri closed 2 months ago

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

PalkaPuri commented 3 months ago

@rfl-urbaniak I reduced the data folder by having only a single experiment of each age, as discussed. Other files can be accessed via drive link mentioned in README.

PalkaPuri commented 2 months ago

Hi, yes, these are just the data files. I ran checks on whether the files are able to be imported & converted to data objects on a separate branch (pp-experimental, in docs/velocity/fish-data-test.ipynb). While the objects can be created without issues, derivation of scores yields errors because of the nan values when fish go missing. That is yet to be solved, and is going to be a separate PR to either chop up the movies or update the score functions. Thought i would import the data for now, in the spirit of keeping PRs small.

rfl-urbaniak commented 2 months ago

I think creating objects and animations still matters as a basic sanity test for data formatting and our animation functions. I agree that derivation and whatnot is a separate issue, but I still would include this basic test in this PR with the idea that changes and modifications should come with a proof that they make sense and some test.

On Mon, Jul 8, 2024, 1:41 PM PalkaPuri @.***> wrote:

Hi, yes, these are just the data files. I ran checks on whether the files are able to be imported & converted to data objects on a separate branch (pp-experimental, in docs/velocity/fish-data-test.ipynb). While the objects can be created without issues, derivation of scores yields errors because of the nan values when fish go missing. That is yet to be solved, and is going to be a separate PR to either chop up the movies or update the score functions. Thought i would import the data for now, in the spirit of keeping PRs small.

— Reply to this email directly, view it on GitHub https://github.com/BasisResearch/collab-creatures/pull/80#issuecomment-2214801620, or unsubscribe https://github.com/notifications/unsubscribe-auth/APEMCZPXQYLY3AAQIDYQKSTZLLFNHAVCNFSM6AAAAABKCKF632VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHAYDCNRSGA . You are receiving this because you were mentioned.Message ID: @.***>

PalkaPuri commented 2 months ago

Alright. Will add a NB demonstrating these tests later in the week and get back to you!

rfl-urbaniak commented 2 months ago

Thanks!

On Wed, Jul 10, 2024, 2:35 PM PalkaPuri @.***> wrote:

Alright. Will add a NB demonstrating these tests later in the week and get back to you!

— Reply to this email directly, view it on GitHub https://github.com/BasisResearch/collab-creatures/pull/80#issuecomment-2221184325, or unsubscribe https://github.com/notifications/unsubscribe-auth/APEMCZMAISLYC5FI6OEKPVLZLV5GFAVCNFSM6AAAAABKCKF632VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGE4DIMZSGU . You are receiving this because you were mentioned.Message ID: @.***>

PalkaPuri commented 2 months ago

I needed the new rescale_to_grid() function to correctly import and display the fish data. So I combined this change with the rescale_to_grid PR (#85). The nb validating the data import is included (docs/experimental/fish/fish_import_checks.ipynb). So I'm closing this PR now!