add min and max to `rescale_to_grid` manually

BasisResearch / collab-creatures

Analyzing animal collaboration with Bayesian and causal inference.

4 stars 1 forks source link

add min and max to `rescale_to_grid` manually #85

Closed rfl-urbaniak closed 1 month ago

rfl-urbaniak commented 1 month ago

Resolves #84 .

rfl-urbaniak commented 1 month ago

add four datasets for minimal testing
format/lint/test using the scripts
run at least two existing notebooks locally to make sure no troubles arise
animate your data after conversion to ensure proper behavior

review-notebook-app[bot] commented 1 month ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

PalkaPuri commented 1 month ago

@rfl-urbaniak -- updated rescale_to_grid, confirmed that it did not break existing code, and also ran checks with imported fish data (docs/experimental/fish/fish_import_checks.ipynb). Have a look when you get a chance. I cannot assign you to review though as the PR was opened by you