BasketLummen / Website

0 stars 6 forks source link

Team image incorrect sized on wide screen #58

Closed Axel8s closed 6 years ago

Axel8s commented 6 years ago

On a 4K screen the bottom half of the team picture is not visible. image

yvesgoeleven commented 6 years ago

@Axel8s I can 'fix' this in 2 ways

Axel8s commented 6 years ago

@yvesgoeleven What we do at our customers to prevent this is limit the max width of the screen to 1024 and show 2 margins on the left and the right: image

This will solve the issue for all pictures, otherwise you will need to edit all pictures. Most users use a 1024 screen and will not notice the margins. Only the widescreen users will see the margin but it keeps the content in focus.

yvesgoeleven commented 6 years ago

@Axel8s that's an option as well (I personally like wide screen images though)

Maybe we can use some smarts to determine the height (and/or center) of the image using computer vision https://azure.microsoft.com/en-us/services/cognitive-services/computer-vision/

Axel8s commented 6 years ago

@yvesgoeleven I see it can recognize faces in one of the examples. So if computer vision can recognize faces and add some space above the highest face and below the lowest face it could work.

yvesgoeleven commented 6 years ago

@axel8s heb zowel de bovenkant van de image afgedaan alsook het frame groter gemaakt. het hoogte verschil tussen thijmen en de coach was te groot om het er met de afzonderlijke maatregelen tussen te laten passen.

yvesgoeleven commented 6 years ago

Het frame van de foto is nu hoger gemaakt