search

Baspar / harbour-picross

Picross game for SailfishOS
4 stars 11 forks source link

Fix SFOS v2.1.0.9: fix ambiguous index variable #4

Closed Tofee closed 6 years ago

Tofee commented 7 years ago

Signed-off-by: Christophe Chapuis chris.chapuis@gmail.com

pimpreneil commented 7 years ago

Thanks @Tofee for fixing that. To celebrate, I am doing a PR with 4 new puzzles 🍾

erikderzweite commented 7 years ago

Is there any reason you choose to use

Levels.arrayToList(myDiff, levelList) instead of Levels.arrayToList(model.index, levelList) ? I'm new to SF development so I'm curious about stuff.

Tofee commented 7 years ago

@erikderzweite There is one technical reason: if you have embedded delegates in the same file, the variable you reference becomes unclear. But the main reason here was that "myDiff" was tested in the line before, and that "myDiff" ("my difficulty") has more meaning then "model.index", which is generic. So it's easier to understand the code.

zarelit commented 6 years ago

This patch is really ready for release, maybe we should ping @Baspar ? :smiley:

Baspar commented 6 years ago

Ouch so sorry for the delay :'( I'm not on sailfish anymore sadly, I left the boat :(

I'll accept this PR, but if someone wants to continue this project, the best solution might be to fork this repo

direc85 commented 5 years ago

Oh, I just now read your previous comment. I just pushed my updated fork to Harbour QA. It's simply called Picross 2.