search

BassT23 / Proxmox

Update your Proxmox VE
Other
192 stars 14 forks source link

updated docker compose section #128

Closed pythongod closed 6 months ago

pythongod commented 6 months ago

updated docker compose section to find more docker compose files and use docker compose to update

not tested with docker compose v1

Gauvino commented 6 months ago

First of all, thank for your contribution it help the project a lot, I'm gonna review this when im home and also try to tested it with docker compose v1 to make sure And also request some typo change !

Gauvino commented 6 months ago

Im gonna try the v1 when I have time

Gauvino commented 6 months ago

After testing it work's like a charm, but I have some request, after adding an option to add a path to find the docker compose. Couldn't test docker-compose v1, but their is not reason for it to not work it's the same only the command change. I was having the idea that not everyone wants their image to be cleaned so, maybe just cleaning the image that's as been updated would be more appropriate.

  1. Clean only updated image
  2. Re-organize, put cleaning after updating

And after all could you squash all the commit and put a proper description in it, or I could if you want. Thanks for your contribution really 🤗

Gauvino commented 6 months ago

Why merging already ?????? https://github.com/BassT23/Proxmox/pull/128#issuecomment-2093023300 ? I didn't approve ? @BassT23

BassT23 commented 6 months ago

you made the changes ;) so ist approved from you, or not?

Gauvino commented 6 months ago

you made the changes ;) so ist approved from you, or not?

No I will approved the change for real if i did click on approved the change, the changed work, I tested it and and request other change. Didn't approved at all

Gauvino commented 6 months ago

I didn't make this image

Gauvino commented 6 months ago

@pythongod could you please make another PR with the changed I requested please?