search

BassT23 / Proxmox

Update your Proxmox VE
Other
192 stars 14 forks source link

Trigger snapshot or backup before update #80

Closed elbim closed 12 months ago

elbim commented 1 year ago

A nice (configurable) feature would be to trigger a snapshot or backup of the machine, before starting the update. That way, you can always roll back very fast and easy, in case an update broke the machine. Snapshot LXC: pct snapshot $CONTAINER \"Update_$(date '+%Y%m%d_%H%M%S')\ Snapshot QM: qm snapshot $VM \"Update_$(date '+%Y%m%d_%H%M%S')\

elbim commented 1 year ago

I forked the master branch and added the code patterns for snapshots to update.conf and update.sh. Maybe if you can spare some time, you'll have a look and give it a try. I hope I got your variable naming right ;) Btw. really like your scripting style.

Gauvino commented 1 year ago

Hello, thanks for your work and if you can make a pull request of if so we can review it and merge !

elbim commented 1 year ago

ah, so that's what these buttons are for :) never commited code to other projects using github, so i hope i got it right.

BassT23 commented 1 year ago

please have a look here: https://github.com/BassT23/Proxmox/discussions/84

BassT23 commented 1 year ago

need to fix the code.

My first problem is: snapshot feature is not available - which ends in exit code. Also need to implement the feature on another line in the script.

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

BassT23 commented 1 year ago

Please check out the new develop version :) Snapshot now work, if disk system allow it.