search

Baste-RainGames / RuntimeScriptField_Unity

A utility for Unity allowing you to assign scripts in the editor, and add them to game objects at runtime.
MIT License
14 stars 4 forks source link

Not setup for UPM #2

Closed mournguard closed 5 years ago

mournguard commented 5 years ago

This repo isn't ready for use with UPM, but it's pretty easy to setup.

I'm trying to get myself a better UPM setup and copying files just isn't gonna work for me, so I forked the repo and created a parallel branch that can be used as a project dependency with UPM.

Check it out

This branch should be replicated here, do not merge those changes in master, obviously.

Let me know what you think, and many thanks for the useful tool. 🎉

Baste-RainGames commented 5 years ago

Hey, thanks! I've been meaning to port my different github utilities to UPM, but I haven't had the time.

If you could make a PR, I'd be happy to look it over and merge it.

mournguard commented 5 years ago

Hey! No problem, but I added the UPM setup (with small cleanup) to another branch so you'd need to create that branch first before I can PR in. We can also just make it a separate repo maybe, or have UPM on master and keep what you have now on another, etc. Let me know how you want to set this up.

Baste-RainGames commented 5 years ago

It looks pretty good, I've made the "package" branch on my repo. There's a few things I'll change, but I can handle that after the pr: I'll change the author field to use my name instead of my github account. Do you know if the author field can be a list? Or if there's a "contributors" field? I'll have to get a thank you to you in there! I'll also want to put the examples back in. I seem to remember that UPM has a magic folder (~Examples or something like that?) that causes the example files to not be automatically included, but be available for import if needed.

After that, there's probably not really a need to have the UPM stuff on a seperate branch/repo. UPM is really, really convenient. If somebody isn't using UPM (eg. people on 2017 LTS), they can just copy over the files, so it's no biggie.

mournguard commented 5 years ago

Sounds good. I don't think there's a contributors field or a list for the authors, but it doesn't matter, github will remember me 😂. I'm not sure about the examples, there's definitely a few folders you can use but I think everything is still included. The documentation for UPM is definitely not as bad as it used to, but it's still a little bit vague.

Check here for information on the manifest itself (Author field)

Check here for information on the package folder structure

Baste-RainGames commented 5 years ago

Package version is now live on the master branch. Thanks for the help!