search

BastiaanJansen / toast-swift

Customizable Swift Toast view built with UIKit. 🍞
MIT License
489 stars 77 forks source link

Add snapshot tests #30

Open Nikoloutsos opened 1 year ago

Nikoloutsos commented 1 year ago

I think it is worth adding some snapshot tests on the views. That way we can be more confident merging PRs. Also, we can add a Github action workflow for running the snapshot tests in every pull request. IIRC github actions are free for open source project ❤️

What do you think? @BastiaanJansen

BastiaanJansen commented 1 year ago

Great idea. I hadn't heard about Snapshot testing. Though I did play around with E2E tests for Swift, but I think Snapshot tests are a better fit! I am familiar with GitHub Actions and use it in my other OS projects as well.

Would you mind looking into it if you have time?

Nikoloutsos commented 1 year ago

Sure, we can do this 😃