search

BastiaanJansen / toast-swift

Customizable Swift Toast view built with UIKit. 🍞
MIT License
489 stars 77 forks source link

There is a library with the same name. #52

Open wlxo0401 opened 9 months ago

wlxo0401 commented 9 months ago

https://github.com/scalessec/Toast-Swift

There is a library with the same name, so wouldn't this be a problem??

I think there can be confusion for people.

https://github.com/danielgindi/Charts

In the case of the existing Charts library, there is a case where the name was changed to DGCharts because the name overlapped with the SwiftUI library.

Nikoloutsos commented 9 months ago

Hello @wlxo0401 thank you for sharing your concern, Indeed when you depend on both you get the following error: CleanShot 2024-01-10 at 12 19 18

OOC did you came up to this issue because your project uses both libraries? I am not sure how easy it is to change the name since I think it will introduce breaking changes to developers.

What do you think?

wlxo0401 commented 9 months ago

Hello @wlxo0401 thank you for sharing your concern, Indeed when you depend on both you get the following error: CleanShot 2024-01-10 at 12 19 18

OOC did you came up to this issue because your project uses both libraries? I am not sure how easy it is to change the name since I think it will introduce breaking changes to developers.

What do you think?

I'm not currently experiencing any issues. However, considering that this library is actively being developed, I'm concerned that as the user base grows, there might be potential issues arising in the future due to the overlapping names of the libraries.

While it's unlikely that many people are using both libraries with the same name, I was concerned about the confusion it could cause in situations like Stackoverflow searches and other similar situation.

Zandor300 commented 8 months ago

The Cocoapods name of this library is ToastViewSwift. Just wanted to mention that for this discussion.