Make bStats 429 Ratelimit errors less scary looking

Bastian / bstats-metrics

The different bStats Metrics classes

https://bStats.org

MIT License

98 stars 114 forks source link

Make bStats 429 Ratelimit errors less scary looking #86

Open Bastian opened 3 years ago

Bastian commented 3 years ago

Currently, a huge stack trace is logged if a 429 Ratelimit errors is encountered (and logFailedRequests is enabled).

Since 429 are expected and are nearly guaranteed to happen once after server startup the error message should be shorter and explain that it is no problem.

isiah-lloyd commented 3 years ago

I agree, I was adding custom chars to my plugin and got the 429 error and assumed it was something wrong with my implementation.

ChrissW-R1 commented 2 years ago

We use a huge stack of plugins. So this "error" occurs many times in the logs. Are there any plans to fix this in the coming releases? The current version 3.0.0 is also affected.

We getting this error for the following list of plugins:

BookRules
CraftBook
DiscordSRV
DriveBackupV2
EasterHunt
Essentials
FastAsyncVoxelSniper
FastAsyncWorldEdit
HeadDatabase
mcMMO
Multiverse-Core
Quests
SilkSpawners
SkinsRestorer
VenturaCalendar
WorldGuard
and also for Paper itself.

Bastian commented 2 years ago

We use a huge stack of plugins. So this "error" occurs many times in the logs. Are there any plans to fix this in the coming releases? The current version 3.0.0 is also affected.

Please just set logFailedRequests to false. It's a debug option that was never intended to be enabled the whole time.

ChrissW-R1 commented 2 years ago

Please just set logFailedRequests to false. It's a debug option that was never intended to be enabled the whole time.

Thanks. This worked for us.