BastianBalthasarBux / tt_address

Add address / contact datasets to your content management system.
GNU General Public License v2.0
4 stars 2 forks source link

If settings.paginate.itemsPerPage is empty there is no output #3

Closed Teisi closed 5 years ago

Teisi commented 7 years ago

I see there is a error handling but i have no output in FE or BE if i have itemsPerPage = 0.

" throw new \RuntimeException('The itemsPerPage is 0 which is not allowed. Please also add "itemsPerPage" to the TS setting settings.overrideFlexformSettingsIfEmpty!', 1400741142); "

respectively

I have no output in FE if itemsPerPage = 0. My workaround is to add a if (in list.html):

Feature request: Can you set a default for this itemsPerPage directly for the content element in the BE?
BastianBalthasarBux commented 7 years ago

i'll have a look at it. thanks for reporting!

BastianBalthasarBux commented 6 years ago

Hmm, I could only partly reproduce. By default, if the field itemsPerPage in Backend is EMPTY, the TypoScript settings are going to be applied, which defaults to 15. See also in setup.ts linke settings.overrideFlexformSettingsIfEmpty = overrideFlexformSettingsIfEmpty = paginate.itemsPerPage, singlePid, recursive

If one enters a zero, yes then there is some exception thrown. Well, I am not sure, what we should do then, instead throwing some exception. I cannot go further within the pagination viewhelper, than that point, because we would simply run into a division by zero ... ;)

BastianBalthasarBux commented 5 years ago

Should be resolved, as we switched to TYPO3 core pagination. If there are still problems, please look at the original repo, as we finally could merge and publish tt_address v 4.0