🐛 fix(front): toggle extension using react state only

[bvelitchkine]

Context

101 : a big problem.

Solution

Never use messaging or storage unless absolutely necessary. I think this should be our development razor in the future. That's what I did here with the toggling of the side panel. More explantions here

Priority

Very High

[GauvainThery]

Before having a look at the code, I disagree with the behaviour. Now it always open a /me page? I think we should clarify what we expect from clicking the icon. I find the behaviour here super confusing.

[GauvainThery]

Just added a few comments! Let's see in sync tomorrow what's best to do 👌

[bvelitchkine]

Call feedback:

• Extension icon opens user's linkedin profile only if not on LinkedIn
• Side panel displays "recruitivity only works on linkedin profiles - yours for instance" if not on a linkedin profile page

[bvelitchkine]

@GauvainThery for some reason, can't see your comments and past review, apart from the comments above. So the only thing I did is implement what we talked about live, but maybe I missed a few things you'd have liked me to change 🤷‍♂️

[bvelitchkine]

Better for sure but still not okay for me. See my comments. Also, not a big fan that everytime I come back onLinkedin I have a very intrusive panel opening that I have to click on to close it. This would make me uninstall the extension...

Why do we display a sidepanel on a page that is not a profile?

Why not just having the popup explicitly say that this extension works on profiles only, and a checkbox "Open automatically whenever I open a profile"

• You're right: let's open automatically on LinkedIn profiles only and close automatically only when the user leaves LinkedIn (like before). I just thought that having one less disjunction would help but you're right, from a UX perspective, it's bad.
• I agree with your comment on the popup. Let's have it display "recruitivity only works on LinkedIn profiles..." + a "...yours for instance ✨" CTA when not on a LinkedIn profile, and do nothing when we're already on a LinkedIn profile.

On that last point:

• No, I don't think the extension click should open the extension anymore. That involves messaging with content scripts and it's exactly why we had bugs. I have a strong opinion on this.
• I don't think we should have that "open automatically" checkbox either (it involves storage and extra unsolicited features users never requested).

Tell me if you agree (at least for this PR)!

[bvelitchkine]

• Cursor pointer on the bubble
• Gif to explain how to open the extension instead of just "enjoy"