search

Bastien-and-Gauvain / monorepo

A chrome extension to help recruiters 1-click export LinkedIn profiles in their Notion databases.
https://chromewebstore.google.com/detail/recruitivity/gahcfmlnmednhnbkifdoffblfffpeljf
3 stars 0 forks source link

✨feat(front) PLAS-15: Text Components in Design System #15

Closed bvelitchkine closed 9 months ago

bvelitchkine commented 9 months ago

Context

In the process of reproducing the original extension, we might need some text paragraphs here and there.

Solution

Three different types of text paragraphs. The only thing that changes is the font size.

Side Note

You'll see some <em> tags here and there: it's just to make sure that HTML could properly be passed as children, and not solely strings.

bvelitchkine commented 9 months ago

PS : I've added a variety of labels to the project. I think we could remove "type(scope)" from the titles of the pull requests as long as we put the two corresponding labels on them. What do you think?

In purple, the types of pull requests:

In green, the possible scopes:

GauvainThery commented 9 months ago

PS : I've added a variety of labels to the project. I think we could remove "type(scope)" from the titles of the pull requests as long as we put the two corresponding labels on them. What do you think?

In purple, the types of pull requests:

  • fix
  • feature
  • improvement

In green, the possible scopes:

  • docs
  • infra
  • design
  • front
  • back

The purpose of naming the PR was to have this name in the commit (even though I haven't found how to name the merge commit with the PR name) and (in the future) trigger different workflow based on the scope of the PR - not sure this is possible with tags 😬

bvelitchkine commented 9 months ago

PS : I've added a variety of labels to the project. I think we could remove "type(scope)" from the titles of the pull requests as long as we put the two corresponding labels on them. What do you think? In purple, the types of pull requests:

  • fix
  • feature
  • improvement

In green, the possible scopes:

  • docs
  • infra
  • design
  • front
  • back

The purpose of naming the PR was to have this name in the commit (even though I haven't found how to name the merge commit with the PR name) and (in the future) trigger different workflow based on the scope of the PR - not sure this is possible with tags 😬

Yeah got it, now I remember. Would be cool if it was though!