Bastien-and-Gauvain / monorepo

A chrome extension to help recruiters 1-click export LinkedIn profiles in their Notion databases.
https://chromewebstore.google.com/detail/recruitivity/gahcfmlnmednhnbkifdoffblfffpeljf
3 stars 0 forks source link

✨ feat(front) PLAS-19 input ds component #16

Closed bvelitchkine closed 1 year ago

bvelitchkine commented 1 year ago

Context

This PR was formerly intended to encompass a single text entry molecule (i.e a text input and its corresponding label). I took upon myself to extend the original requirement and also add a dropdown select entry (i.e select input + label) to the task.

Solution

Hence, the is what has been developed:

Unsurprisingly, you'll see how it all articulates when running pnpm storybook

bvelitchkine commented 1 year ago

Side notes:

  1. Yes, the commit history is a bit messy as I had created the branch before the latest code was on github, then pulled remote changes to my local master branch, and then merged the master branch into the branch I had first created.
  2. Yes, there's more in this PR than in previous ones. Should I have split the text form entry and the select form entry in two distinct PRs? Please let me know.
bvelitchkine commented 1 year ago

And yes, I'll have to extend the dropdown select component. I've only built a basic one, but the smaller dark blue one (for notion db selection) is still missing. That's for another PR.

bvelitchkine commented 1 year ago

I created the alternative dropdown after all :)

GauvainThery commented 1 year ago

Side notes:

  1. Yes, the commit history is a bit messy as I had created the branch before the latest code was on github, then pulled remote changes to my local master branch, and then merged the master branch into the branch I had first created.
  2. Yes, there's more in this PR than in previous ones. Should I have split the text form entry and the select form entry in two distinct PRs? Please let me know.

No worries, honestly we don't care about commits! And as long as you're under 500 lines to review, it's fine for me!

bvelitchkine commented 1 year ago

So now, there's only one remaining comment I'm not quite sure how to deal with, but apart from that, we're good I guess