Bastien-and-Gauvain / monorepo

A chrome extension to help recruiters 1-click export LinkedIn profiles in their Notion databases.
https://chromewebstore.google.com/detail/recruitivity/gahcfmlnmednhnbkifdoffblfffpeljf
3 stars 0 forks source link

🎨 improvement(front) PLAS-047: Handle 'Go Back' in LinkedIn #24

Closed bvelitchkine closed 9 months ago

bvelitchkine commented 9 months ago

Problem

image Here's what used to happen:

  1. We'd visit a first profile on LinkedIn
  2. The data would be scraped and fill the extension fields
  3. We'd visit another profile on LinkedIn
  4. The data would - once again - be scraped and fill the extension fields.
  5. Then we'd click on 'go back' in the browser to roll back to the first profile (cf. pink highlight on screenshot above)
  6. Its data would not be scraped

Solution

It's not the cleanest of solutions but it's the only one I found: a mere setTimeout of 2s... Anyway, that works seemlessly.

bvelitchkine commented 9 months ago

If you agree with every comment above, I'll implement the changes ;)

GauvainThery commented 9 months ago

If you agree with every comment above, I'll implement the changes ;)

Next implement first and ask then for a review, it's a mess to review in the comments especially as we're modifying the same lines.

Regarding what you said, I think we're just loosing some time on stuff not so important so far so let's just carry on and merge 💪

bvelitchkine commented 9 months ago

Couldn't put the timeout in the service worker. I had to leave it in the content script. Not a big deal though, I'll merge.