search

Bastien-and-Gauvain / monorepo

A chrome extension to help recruiters 1-click export LinkedIn profiles in their Notion databases.
https://chromewebstore.google.com/detail/recruitivity/gahcfmlnmednhnbkifdoffblfffpeljf
3 stars 0 forks source link

✨ feat(front) PLAS-018: 'Go Back To LinkedIn' CTA #25

Closed bvelitchkine closed 9 months ago

bvelitchkine commented 9 months ago

When user tries to open the extension (by clicking on its icon) on a page that's not LinkedIn, instead of the usual side panel, we display one with a call to action to open his own profile on LinkedIn.

bvelitchkine commented 9 months ago

Regarding the options you mentioned, I've actually explored both:

  1. If by a popup, you mean THE popup (the default one), then the problem is that the popup will always open when we click on the icon, even on LinkedIn. And by doing so, it will also disable the toggling option you've implemented. That's why I ruled this one out. If you just mean A popup, then, what I did is just that.
  2. I started like that actually. Let's assume we went that way. Then the side panel would have not only to open on LinkedIn but everywhere else on the web. So we'd have to change the plasmo config to not only match linkedin urls. Fair enough. But then we'd also have to change useEffect right there because scraping wouldn't work on non-linkedin pages. Finally, we'd have more complicated rendering logic in the component.

Does that make sense?

GauvainThery commented 9 months ago

Regarding the options you mentioned, I've actually explored both:

  1. If by a popup, you mean THE popup (the default one), then the problem is that the popup will always open when we click on the icon, even on LinkedIn. And by doing so, it will also disable the toggling option you've implemented. That's why I ruled this one out. If you just mean A popup, then, what I did is just that.
  2. I started like that actually. Let's assume we went that way. Then the side panel would have not only to open on LinkedIn but everywhere else on the web. So we'd have to change the plasmo config to not only match linkedin urls. Fair enough. But then we'd also have to change useEffect right there because scraping wouldn't work on non-linkedin pages. Finally, we'd have more complicated rendering logic in the component.

Does that make sense?

Thanks for the detailed reply! I meant indeed THE popup but I didn't know we couldn't choose what to open on the onClick of the extension icon.

I'd go with the same comment as the other PR. I think I'm being too meticulous here for things that are actually well implemented and can be change easily later. So let's go for it 🚀