search

Bastien-and-Gauvain / monorepo

A chrome extension to help recruiters 1-click export LinkedIn profiles in their Notion databases.
https://chromewebstore.google.com/detail/recruitivity/gahcfmlnmednhnbkifdoffblfffpeljf
3 stars 0 forks source link

🎨 impr(front,design) PLAS-062: New Form Entries #49

Closed bvelitchkine closed 8 months ago

bvelitchkine commented 8 months ago

Context

The design revamping goes on. Form entries have been significantly improved. We're now able to build proper forms and complete layouts.

Solution

Two things you should know:

  1. Some components props have changed here and there and might've broken a view or two. I chose not to care because these layouts are about to be revamped as well.
  2. I have installed a new heroicons package. Our icons were too difficult to resize, especially the chevron in the custom dropdown select. I believe we should replace the old SVG icons with the new ones just as well.

Therefore, don't forget to pnpm install the new package before running pnpm storybook 😉

Priority

High

bvelitchkine commented 8 months ago

Following your suggestions, I modified my code + spotted a mismanagement of 'label' vs 'values' in my dropdown select (see related commit for additional info).

As far as I'm concerned, I think we could merge this PR as is.