[BUG] Upgrading bootstrap release retains old dir name (dataset)

[michael-o]

[MANDATORY] Describe the bug [MANDATORY] When you update your bootstrap release from 12.2-RELEASE to 12.3-RELEASE the mountpoint still retains old name.

[MANDATORY] Bastille and FreeBSD version (paste bastille -v && freebsd-version -kru output)

[MANDATORY] How did you install bastille? (port/pkg/git) port

[optional] Steps to reproduce?

# zfs list | grep 12.2
hp-large/bastille/cache/12.2-RELEASE         175M   351G   175M  /usr/local/bastille/cache/12.2-RELEASE
hp-large/bastille/releases/12.2-RELEASE      461M   351G   461M  /usr/local/bastille/releases/12.2-RELEASE
# bastille upgrade 12.2-RELEASE 12.3-RELEASE
...

The mountpoint remains as 12.2-RELEASE.

[optional] Expected behavior I would expect a move to 12.3-RELEASE on FS level too. I know that thin jails are affected as well. Alternatively, one would bootstrap 12.3-RELEASE and then an upgrade on thin jails would remount the base system and update all files in /etc.

For now, this is somewhat problematic.

[joh-ku]

I noticed the same behavior for thin jails as already mentioned by @michael-o. I think a combination of bootstrap and some kind of migrate/upgrade command, that changes/remounts affected jails would mitigate this limitation.

I can think of something like:

bastille bootstrap 12.3-RELEASE
bastille upgrade myjail 12.3-RELEASE

This would also allow for different basejail releases.

[bmac2]

bastille upgrade is being depreciated and removed per @cedwards

[michael-o]

bastille upgrade is being depreciated and removed per @cedwards

Where is this written? Neither docs nor https://github.com/BastilleBSD/bastille/releases/tag/0.10.20231013 mention it.

[bmac2]

we haven't done it yet, was put on the roadmap by @cedwards last night.