search

BatchDrake / SigDigger

Qt-based digital signal analyzer, using Suscan core and Sigutils DSP library
https://batchdrake.github.io/SigDigger/
GNU General Public License v3.0
925 stars 91 forks source link

Misc improvements #231

Closed sultanqasim closed 6 months ago

sultanqasim commented 10 months ago
BatchDrake commented 9 months ago

Looks good too, will test it along with your PR for suscan. Thanks!

BatchDrake commented 9 months ago

There's a little UI issue with these changes in the Source config tab (ProfileConfigTab). If you attempt to navigate through all source types with the mouse wheel or the arrow keys, sometimes the current source type is not reflected in the source type combo / source config UI stack (although it does in the ProfileConfigTab state and the underlying Suscan::Source::Config object).

sultanqasim commented 9 months ago

Thanks for your testing, I’ll look into that bug

melroy89 commented 7 months ago

@BatchDrake you need some help with those failing tests?

BatchDrake commented 7 months ago

Hi,

I plan to get back to this soon, but I am afraid I will not find time until the week of December 18th or so.

Cheers,

sultanqasim commented 7 months ago

I need to recreate the bug BatchDrake encountered regarding ProfileConfigTab and then find the root cause. Maybe I’ll have time this week.

BatchDrake commented 6 months ago

Fixed. It had to do with signals being emitted at the wrong time (source config widget activation). I've just prevented this explicitly.

sultanqasim commented 6 months ago

Thanks for figuring this out! Sorry, I haven’t gotten to spend much time on SigDigger lately though I’m still hoping to get back to it soon.

BatchDrake commented 6 months ago

No worries, I was waiting for a 3D print to finish and decided to close as many PRs as possible today :)

El sáb., 20 ene. 2024 21:07, Sultan Qasim Khan @.***> escribió:

Thanks for figuring this out! Sorry, I haven’t gotten to spend much time on SigDigger lately though I’m still hoping to get back to it soon.

— Reply to this email directly, view it on GitHub https://github.com/BatchDrake/SigDigger/pull/231#issuecomment-1902254128, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEVETYYDDMSZ65FLLIC2BTYPQPZXAVCNFSM6AAAAAA4ZMUXACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSGI2TIMJSHA . You are receiving this because you modified the open/close state.Message ID: @.***>