search

BatchDrake / SigDigger

Qt-based digital signal analyzer, using Suscan core and Sigutils DSP library
https://batchdrake.github.io/SigDigger/
GNU General Public License v3.0
952 stars 93 forks source link

Decimation improvement #83

Open mehdideveloper opened 4 years ago

mehdideveloper commented 4 years ago

I have some feedback regarding the decimation input box:

1- To my knowledge, people only use limited decimation values, right? Like 1,2,4,10, etc. Maybe there's a maximum to it? Otherwise, they would just use smaller sample rates, instead of selecting a big sample rate and applying decimation. With this in mind, I think maybe a combo-box of values from say 1 to 10 would be better than a text box.

2- Even if you don't agree with the previous suggestion, maybe there should be an upper limit to what people can enter for the value?

3- What about letting the user change the decimation rate while using the app?

BatchDrake commented 4 years ago

It already is, I think you cannot decimate above 100, although this is quite arbitrary. Changing that is not complicated, but I would prefer to fix bugs first.

Also, changing the decimation rate while running the app is a major change that cannot be handled easily: let's say you are capturing at 8 Msps and listening to some channel 3 MHz above the center frequency. Then you change decimation to 2: the DSP chain rate is now 4 Msps. What do we do with the audio inspector? This applies not only to audio but to any channel inspector.