search

BatedUrGonnaDie / glitchify

Tweaks for the official twitch.tv android app
https://forum.xda-developers.com/xposed/modules/mod-glitchify-tweaks-additions-official-t3483569
MIT License
34 stars 5 forks source link

Update for Twitch 8.6.1 #16

Closed dcoolArne closed 4 years ago

dcoolArne commented 4 years ago

It works, but i am not sure if the Badges are right, because the method got renamed and i am not sure if it is pulling the correct name. Also something with the bits got changed and i cant really test that.

dcoolArne commented 4 years ago

Update for 8.6.1 since i got a new Update Today

BatedUrGonnaDie commented 4 years ago

Can you squash this down into one commit? And I'll take a look at it this weekend and make sure everything is working properly.

dcoolArne commented 4 years ago

It should all be correct now.

dcoolArne commented 4 years ago

Something with bits doesn't really work yet, but I can't really look into it until Monday.

BatedUrGonnaDie commented 4 years ago

It sounds like you're still working on this so I'll take a look when you give me the go ahead that you're done.

dcoolArne commented 4 years ago

I am not really sure what to do, because I got a one time stacktrace (no crash). I think it gets triggerd from split bits, because one class that you checked for got removed in 8.5.1. If you look at the code I just commented it out, but I couldn't really find its use.

BatedUrGonnaDie commented 4 years ago

Ok, I will take a look at this today then.

EDIT: Got distracted today, will look at it sometime this week.

NBruderman commented 4 years ago

Any news on the matter? Btw, version 8.7.x is out

NBruderman commented 4 years ago

Or at least merge this for the 8.6.x?

dcoolArne commented 4 years ago

I can't merge it on my own, but if you want you can download the repo and compile it yourself

NBruderman commented 4 years ago

Yeah, I know, hopefully @BatedUrGonnaDie will respond and help

BatedUrGonnaDie commented 4 years ago

Sorry for ghosting you on this one. I don't really remember what ChommentModel was for, I think it was something to do with VOD's and there just being an insane amount of errors being thrown. I'm just going to merge this as the code itself looks good.

NBruderman commented 4 years ago

Any chance of building it and releasing it on the xposed module? Or you don't want because it's not the latest version?

BatedUrGonnaDie commented 4 years ago

BTTV updated their API version some time ago and broke badges currently, and others things can break whenever. I'm working to update the code to use their new version, and fix another badge related change from twitch and then I'll release it for 8.6.X.

NBruderman commented 4 years ago

Btw, really sorry. For some reason, I were sure that version 8.7.0 was out. Apparently I was wrong.

BatedUrGonnaDie commented 4 years ago

Shit happens ¯\_(ツ)_/¯