search

Batfoxkid / Freak-Fortress-2-Rewrite

The gamemode that's now also a standalone boss maker.
https://forums.alliedmods.net/forumdisplay.php?f=154
GNU General Public License v3.0
17 stars 7 forks source link

[Bug] attribute 296 `sapper kills collect crits` doesn't work as we intended #171

Closed M60TM closed 5 months ago

M60TM commented 7 months ago

Description

As intended, the higher the value of attribute 296, the more critical should be given, but if the value is higher than 1, it will not work.

Reproduce

Steps to reproduce the behavior:

  1. Setting sapper kills collect crits to any higher value than 1 on diamondback.
  2. Backstab boss and See.

Reason

bool SapperKillsCollectCrits( void ) const { int iMode = 0; CALL_ATTRIB_HOOK_INT( iMode, sapper_kills_collect_crits ); return (iMode == 1); };

M60TM commented 7 months ago

As a result of decompiling server_srv.so, the function above no longer exists and is hard-coded within each function. I was thinking of using DHooks for this, but it became impossible.

Batfoxkid commented 5 months ago

Overriding the SapperKillsCollectCrits might be out of scope for FF2 specifically.