search

Batfoxkid / FreakFortressBat

No longer supported.
https://github.com/Batfoxkid/Freak-Fortress-2-Rewrite
GNU General Public License v3.0
30 stars 20 forks source link

[Bug] New 1.20.0 Errors #136

Open MAGNAT2645 opened 4 years ago

MAGNAT2645 commented 4 years ago

SPAMS this:

L 08/12/2020 - 11:35:35: [SM] Exception reported: Property "m_bDisabled" not found (entity 0/worldspawn)
L 08/12/2020 - 11:35:35: [SM] Blaming: freaks/ff2_dynamic_defaults.ff2
L 08/12/2020 - 11:35:35: [SM] Call stack trace:
L 08/12/2020 - 11:35:35: [SM]   [0] SetEntProp
L 08/12/2020 - 11:35:35: [SM]   [1] Line 1436, FF2 Subplugin: Dynamic Defaults::DSSG_PerformUnstunActions
L 08/12/2020 - 11:35:35: [SM]   [2] Line 1478, FF2 Subplugin: Dynamic Defaults::DSSG_Tick
L 08/12/2020 - 11:35:35: [SM]   [3] Line 2702, FF2 Subplugin: Dynamic Defaults::OnGameFrame

Other errors:

L 08/12/2020 - 11:30:21: [SM] Exception reported: Invalid Handle 52b20e5d (error: 1)
L 08/12/2020 - 11:30:21: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/12/2020 - 11:30:21: [SM] Call stack trace:
L 08/12/2020 - 11:30:21: [SM]   [0] ArrayList.Push
L 08/12/2020 - 11:30:21: [SM]   [1] Line 603, Unofficial Freak Fortress::FF2Protected.PushToTail
L 08/12/2020 - 11:30:21: [SM]   [2] Line 658, Unofficial Freak Fortress::FF2Protected.Request
L 08/12/2020 - 11:30:21: [SM]   [3] Line 3931, Unofficial Freak Fortress::OnRoundStart
L 08/12/2020 - 11:30:21: [SM] Exception reported: Invalid Handle 52b20e5d (error: 1)
L 08/12/2020 - 11:30:21: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/12/2020 - 11:30:21: [SM] Call stack trace:
L 08/12/2020 - 11:30:21: [SM]   [0] ArrayList.Push
L 08/12/2020 - 11:30:21: [SM]   [1] Line 603, Unofficial Freak Fortress::FF2Protected.PushToTail
L 08/12/2020 - 11:30:21: [SM]   [2] Line 658, Unofficial Freak Fortress::FF2Protected.Request
L 08/12/2020 - 11:30:21: [SM]   [3] Line 15194, Unofficial Freak Fortress::GetArgumentF
L 08/12/2020 - 11:30:21: [SM]   [4] Line 15158, Unofficial Freak Fortress::GetAbilityArgumentFloat
L 08/12/2020 - 11:30:21: [SM]   [5] Line 17743, Unofficial Freak Fortress::Native_GetAbilityArgumentFloat
L 08/12/2020 - 11:30:21: [SM]   [7] FF2_GetAbilityArgumentFloat
L 08/12/2020 - 11:30:21: [SM]   [8] Line 276, C:\Games\tf2server\tf\addons\sourcemod\scripting\freaks\ff2_death.sp::Event_RoundStart
L 08/12/2020 - 11:30:21: [SM] Exception reported: Invalid Handle 52b20e5d (error: 1)
L 08/12/2020 - 11:30:21: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/12/2020 - 11:30:21: [SM] Call stack trace:
L 08/12/2020 - 11:30:21: [SM]   [0] ArrayList.Push
L 08/12/2020 - 11:30:21: [SM]   [1] Line 603, Unofficial Freak Fortress::FF2Protected.PushToTail
L 08/12/2020 - 11:30:21: [SM]   [2] Line 658, Unofficial Freak Fortress::FF2Protected.Request
L 08/12/2020 - 11:30:21: [SM]   [3] Line 15194, Unofficial Freak Fortress::GetArgumentF
L 08/12/2020 - 11:30:21: [SM]   [4] Line 15158, Unofficial Freak Fortress::GetAbilityArgumentFloat
L 08/12/2020 - 11:30:21: [SM]   [5] Line 17743, Unofficial Freak Fortress::Native_GetAbilityArgumentFloat
L 08/12/2020 - 11:30:21: [SM]   [7] FF2_GetAbilityArgumentFloat
L 08/12/2020 - 11:30:21: [SM]   [8] Line 406, FF2 Subplugin: Dynamic Defaults::Event_RoundStart

EDIT:

L 08/12/2020 - 11:36:32: [SM] Exception reported: Invalid Handle 52b20e5d (error: 3)
L 08/12/2020 - 11:36:32: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/12/2020 - 11:36:32: [SM] Call stack trace:
L 08/12/2020 - 11:36:32: [SM]   [0] ArrayList.Length.get
L 08/12/2020 - 11:36:32: [SM]   [1] Line 674, Unofficial Freak Fortress::FF2Protected.Purge
L 08/12/2020 - 11:36:32: [SM]   [2] Line 2231, Unofficial Freak Fortress::DisableFF2
L 08/12/2020 - 11:36:32: [SM]   [3] Line 2050, Unofficial Freak Fortress::OnConfigsExecuted
L 08/12/2020 - 11:36:11: [SM] Exception reported: Invalid Handle 52b20e5d (error: 3)
L 08/12/2020 - 11:36:11: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/12/2020 - 11:36:11: [SM] Call stack trace:
L 08/12/2020 - 11:36:11: [SM]   [0] ArrayList.Length.get
L 08/12/2020 - 11:36:11: [SM]   [1] Line 674, Unofficial Freak Fortress::FF2Protected.Purge
L 08/12/2020 - 11:36:11: [SM]   [2] Line 2231, Unofficial Freak Fortress::DisableFF2
L 08/12/2020 - 11:36:11: [SM]   [3] Line 2095, Unofficial Freak Fortress::OnMapEnd
HotoCocoaco commented 4 years ago

And console spams this when using 'dynamic_melee_management' with v1.20.0

L 08/12/2020 - 13:47:20: [SM] Blaming: freaks\ff2_dynamic_defaults.ff2
L 08/12/2020 - 13:47:20: [SM] Call stack trace:
L 08/12/2020 - 13:47:20: [SM]   [0] TF2Items_GiveNamedItem
L 08/12/2020 - 13:47:20: [SM]   [1] Line 2994, freaks\ff2_dynamic_defaults.sp::SpawnWeapon
L 08/12/2020 - 13:47:20: [SM]   [2] Line 1634, freaks\ff2_dynamic_defaults.sp::DMM_ResetWeapon
L 08/12/2020 - 13:47:20: [SM]   [3] Line 2736, freaks\ff2_dynamic_defaults.sp::OnPlayerRunCmd
L 08/12/2020 - 13:47:20: [TF2ITEMS] ---------------------------------------
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> szClassname = 
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> iItemDefinitionIndex = 0
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> iEntityQuality = 5
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> iEntityLevel = 101
L 08/12/2020 - 13:47:20: [TF2ITEMS] ---------------------------------------
L 08/12/2020 - 13:47:20: [SM] Exception reported: Item is NULL. File a bug report if you are sure you set all the data correctly. (Try the FORCE_GENERATION flag.)
MAGNAT2645 commented 4 years ago

And console spams this when using 'dynamic_melee_management' with v1.20.0

L 08/12/2020 - 13:47:20: [SM] Blaming: freaks\ff2_dynamic_defaults.ff2
L 08/12/2020 - 13:47:20: [SM] Call stack trace:
L 08/12/2020 - 13:47:20: [SM]   [0] TF2Items_GiveNamedItem
L 08/12/2020 - 13:47:20: [SM]   [1] Line 2994, freaks\ff2_dynamic_defaults.sp::SpawnWeapon
L 08/12/2020 - 13:47:20: [SM]   [2] Line 1634, freaks\ff2_dynamic_defaults.sp::DMM_ResetWeapon
L 08/12/2020 - 13:47:20: [SM]   [3] Line 2736, freaks\ff2_dynamic_defaults.sp::OnPlayerRunCmd
L 08/12/2020 - 13:47:20: [TF2ITEMS] ---------------------------------------
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> szClassname = 
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> iItemDefinitionIndex = 0
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> iEntityQuality = 5
L 08/12/2020 - 13:47:20: [TF2ITEMS] >>> iEntityLevel = 101
L 08/12/2020 - 13:47:20: [TF2ITEMS] ---------------------------------------
L 08/12/2020 - 13:47:20: [SM] Exception reported: Item is NULL. File a bug report if you are sure you set all the data correctly. (Try the FORCE_GENERATION flag.)

This also happens with rage_new_weapon

MAGNAT2645 commented 4 years ago

There's also new errors in ff2_errors.log (v1.20.0, didn't test in v1.20.1):

L 08/12/2020 - 13:37:05: [disabled/freak_fortress_2.smx] [FF2] Exception reported: Boss: -1 - Name: Unknown
L 08/12/2020 - 13:37:05: [disabled/freak_fortress_2.smx] [FF2] [Boss] Invalid entity while spawning objects for ffbat_defaults-check your configs!
MAGNAT2645 commented 4 years ago

Also abilities with TF2Items_GiveNamedItem still throw error like:

L 08/13/2020 - 12:05:30: [TF2ITEMS] ---------------------------------------
L 08/13/2020 - 12:05:30: [TF2ITEMS] >>> szClassname = 
L 08/13/2020 - 12:05:30: [TF2ITEMS] >>> iItemDefinitionIndex = 0
L 08/13/2020 - 12:05:30: [TF2ITEMS] >>> iEntityQuality = 5
L 08/13/2020 - 12:05:30: [TF2ITEMS] >>> iEntityLevel = 101
L 08/13/2020 - 12:05:30: [TF2ITEMS] ---------------------------------------
L 08/13/2020 - 12:05:30: [SM] Exception reported: Item is NULL. File a bug report if you are sure you set all the data correctly. (Try the FORCE_GENERATION flag.)
L 08/13/2020 - 12:05:30: [SM] Blaming: freaks/improved_saxton.ff2
L 08/13/2020 - 12:05:30: [SM] Call stack trace:
L 08/13/2020 - 12:05:30: [SM]   [0] TF2Items_GiveNamedItem
L 08/13/2020 - 12:05:30: [SM]   [1] Line 1928, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freaks\improved_saxton.sp::SpawnWeapon
L 08/13/2020 - 12:05:30: [SM]   [2] Line 1487, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freaks\improved_saxton.sp::SB_SwapWeapon
L 08/13/2020 - 12:05:30: [SM]   [3] Line 494, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freaks\improved_saxton.sp::Timer_PostRoundStartInits
L 08/13/2020 - 12:07:47: [TF2ITEMS] ---------------------------------------
L 08/13/2020 - 12:07:47: [TF2ITEMS] >>> szClassname = 
L 08/13/2020 - 12:07:47: [TF2ITEMS] >>> iItemDefinitionIndex = 0
L 08/13/2020 - 12:07:47: [TF2ITEMS] >>> iEntityQuality = 5
L 08/13/2020 - 12:07:47: [TF2ITEMS] >>> iEntityLevel = 101
L 08/13/2020 - 12:07:47: [TF2ITEMS] ---------------------------------------
L 08/13/2020 - 12:07:47: [SM] Exception reported: Item is NULL. File a bug report if you are sure you set all the data correctly. (Try the FORCE_GENERATION flag.)
L 08/13/2020 - 12:07:47: [SM] Blaming: freaks/ffbat_defaults.ff2
L 08/13/2020 - 12:07:47: [SM] Call stack trace:
L 08/13/2020 - 12:07:47: [SM]   [0] TF2Items_GiveNamedItem
L 08/13/2020 - 12:07:47: [SM]   [1] Line 1034, C:\Users\batfo\Documents\SourceMod 1.10 Compiler\scripting\include\freak_fortress_2.inc::FF2_SpawnWeapon
L 08/13/2020 - 12:07:47: [SM]   [2] Line 932, FF2 Unofficial Subplugin: Defaults::Rage_New_Weapon
L 08/13/2020 - 12:07:47: [SM]   [3] Line 253, FF2 Unofficial Subplugin: Defaults::FF2_OnAbility2
L 08/13/2020 - 12:07:47: [SM]   [4] Line 48, C:\Users\batfo\Documents\SourceMod 1.10 Compiler\scripting\include\freak_fortress_2_subplugin.inc::FF2_OnAbility
L 08/13/2020 - 12:07:47: [SM]   [6] Call_Finish
L 08/13/2020 - 12:07:47: [SM]   [7] Line 17190, Unofficial Freak Fortress::UseAbility
L 08/13/2020 - 12:07:47: [SM]   [8] Line 11513, Unofficial Freak Fortress::ActivateAbilitySlot
L 08/13/2020 - 12:07:47: [SM]   [9] Line 11454, Unofficial Freak Fortress::OnCallForMedic
L 08/13/2020 - 12:17:08: [TF2ITEMS] ---------------------------------------
L 08/13/2020 - 12:17:08: [TF2ITEMS] >>> szClassname = 
L 08/13/2020 - 12:17:08: [TF2ITEMS] >>> iItemDefinitionIndex = 0
L 08/13/2020 - 12:17:08: [TF2ITEMS] >>> iEntityQuality = 5
L 08/13/2020 - 12:17:08: [TF2ITEMS] >>> iEntityLevel = 101
L 08/13/2020 - 12:17:08: [TF2ITEMS] ---------------------------------------
L 08/13/2020 - 12:17:08: [SM] Exception reported: Item is NULL. File a bug report if you are sure you set all the data correctly. (Try the FORCE_GENERATION flag.)
L 08/13/2020 - 12:17:08: [SM] Blaming: freaks/ff2_dynamic_defaults.ff2
L 08/13/2020 - 12:17:08: [SM] Call stack trace:
L 08/13/2020 - 12:17:08: [SM]   [0] TF2Items_GiveNamedItem
L 08/13/2020 - 12:17:08: [SM]   [1] Line 1034, C:\Users\batfo\Documents\SourceMod 1.10 Compiler\scripting\include\freak_fortress_2.inc::FF2_SpawnWeapon
L 08/13/2020 - 12:17:08: [SM]   [2] Line 1639, FF2 Subplugin: Dynamic Defaults::DMM_ResetWeapon
L 08/13/2020 - 12:17:08: [SM]   [3] Line 2741, FF2 Subplugin: Dynamic Defaults::OnPlayerRunCmd
MAGNAT2645 commented 4 years ago

Still almost every ability is broken (even AMS-based). Bosses can't use stun, teleport doesn't have cooldown, minions spawn with their loadout weapons and have class-based models (but not ones from config). EasterDemo's grenade launcher has default bomb models but not easter eggs, Skeleton King has unlimited lifes because he doesn't have cooldown on reincarnation. And MORE...

FF2 throws errors like:

L 08/13/2020 - 14:35:38: [disabled/freak_fortress_2.smx] [FF2] Exception reported: Boss: 0 - Name: Seeman
L 08/13/2020 - 14:35:38: [disabled/freak_fortress_2.smx] [FF2] [Boss] Invalid entity while spawning objects for ffbat_defaults-check your configs!

SO, you should check every error i have posted here. If this happens with every ability it might be something wrong with UseAbility, ActivateAbilitySlot (or any function that reads config values).

Some proofs (special_dropprop): изображение изображение (note that bug with weapon classname on HUD is still there...)

01Pollux commented 4 years ago

Note: all of this happening because of "UTIL_FindCharArg" failing and returning default value (0) or an empty string. that's why none of the FF2_GetAbilityArgument*() is working properly.

139

It's extremly hard to look at source code with phone, even impossible because for whatever reason it doesnt show me the full code. I apologize for the trouble and will try to fix it asap later.

MAGNAT2645 commented 4 years ago

It fails to compile:

    C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp(588) : error 010: invalid function or declaration
    C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp(588) : error 009: invalid array size (negative, zero or out of bounds)
    C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp(631) : error 163: indeterminate array size in "sizeof" expression (symbol "g_FF2Saved")
    C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp(658) : error 163: indeterminate array size in "sizeof" expression (symbol "g_FF2Saved")
    C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp(667) : error 163: indeterminate array size in "sizeof" expression (symbol "g_FF2Saved")
    C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp(713) : error 163: indeterminate array size in "sizeof" expression (symbol "g_FF2Saved")

The problem is MAXBOSSES which is not a constant value but a function and you can't declare fixed array with non-constant size.

01Pollux commented 4 years ago

should compile now, did not notice it was using "MaxClients" :P

MAGNAT2645 commented 4 years ago

There's also errors like:

L 08/13/2020 - 15:53:25: [SM] Exception reported: Invalid Handle 1f1a0c5d (error: 1)
L 08/13/2020 - 15:53:25: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/13/2020 - 15:53:25: [SM] Call stack trace:
L 08/13/2020 - 15:53:25: [SM]   [0] ArrayList.Length.get
L 08/13/2020 - 15:53:25: [SM]   [1] Line 672, Unofficial Freak Fortress::FF2Protected.Purge
L 08/13/2020 - 15:53:25: [SM]   [2] Line 2229, Unofficial Freak Fortress::DisableFF2
L 08/13/2020 - 15:53:25: [SM]   [3] Line 2093, Unofficial Freak Fortress::OnMapEnd
08/13/2020 - 15:53:22: [SM] Exception reported: Invalid Handle 1f1a0c5d (error: 1)
L 08/13/2020 - 15:53:22: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/13/2020 - 15:53:22: [SM] Call stack trace:
L 08/13/2020 - 15:53:22: [SM]   [0] ArrayList.Push
L 08/13/2020 - 15:53:22: [SM]   [1] Line 601, Unofficial Freak Fortress::FF2Protected.PushToTail
L 08/13/2020 - 15:53:22: [SM]   [2] Line 656, Unofficial Freak Fortress::FF2Protected.Request
L 08/13/2020 - 15:53:22: [SM]   [3] Line 15172, Unofficial Freak Fortress::GetArgumentI
L 08/13/2020 - 15:53:22: [SM]   [4] Line 15149, Unofficial Freak Fortress::GetAbilityArgument
L 08/13/2020 - 15:53:22: [SM]   [5] Line 17691, Unofficial Freak Fortress::Native_GetAbilityArgument
L 08/13/2020 - 15:53:22: [SM]   [7] FF2_GetAbilityArgument
L 08/13/2020 - 15:53:22: [SM]   [8] Line 392, G:\Scripting\addons\sourcemod\scripting\m7_abilities_extended.sp::event_player_death
L 08/13/2020 - 15:53:22: [SM] Exception reported: Invalid Handle 1f1a0c5d (error: 1)
L 08/13/2020 - 15:53:22: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/13/2020 - 15:53:22: [SM] Call stack trace:
L 08/13/2020 - 15:53:22: [SM]   [0] ArrayList.Push
L 08/13/2020 - 15:53:22: [SM]   [1] Line 601, Unofficial Freak Fortress::FF2Protected.PushToTail
L 08/13/2020 - 15:53:22: [SM]   [2] Line 656, Unofficial Freak Fortress::FF2Protected.Request
L 08/13/2020 - 15:53:22: [SM]   [3] Line 15172, Unofficial Freak Fortress::GetArgumentI
L 08/13/2020 - 15:53:22: [SM]   [4] Line 15149, Unofficial Freak Fortress::GetAbilityArgument
L 08/13/2020 - 15:53:22: [SM]   [5] Line 17691, Unofficial Freak Fortress::Native_GetAbilityArgument
L 08/13/2020 - 15:53:22: [SM]   [7] FF2_GetAbilityArgument
L 08/13/2020 - 15:53:22: [SM]   [8] Line 900, C:\Games\tf2server\tf\addons\sourcemod\scripting\freaks\shadow93_bosses.sp::OnPlayerDeath
L 08/13/2020 - 15:53:05: [SM] Exception reported: Invalid Handle 1f1a0c5d (error: 1)
L 08/13/2020 - 15:53:05: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/13/2020 - 15:53:05: [SM] Call stack trace:
L 08/13/2020 - 15:53:05: [SM]   [0] ArrayList.Length.get
L 08/13/2020 - 15:53:05: [SM]   [1] Line 663, Unofficial Freak Fortress::FF2Protected.Cleanup
L 08/13/2020 - 15:53:05: [SM]   [2] Line 4195, Unofficial Freak Fortress::OnRoundEnd
L 08/13/2020 - 15:53:05: [SM] Exception reported: No matching callback was registered
L 08/13/2020 - 15:53:05: [SM] Blaming: freaks/ff2_sarysapub3.ff2
L 08/13/2020 - 15:53:05: [SM] Call stack trace:
L 08/13/2020 - 15:53:05: [SM]   [0] RemoveCommandListener
L 08/13/2020 - 15:53:05: [SM]   [1] Line 622, L:\scripting\ff2_sarysapub3.sp::Event_RoundEnd
L 08/13/2020 - 15:53:04: [SM] Exception reported: Array index out-of-bounds (index 286280, limit 36)
L 08/13/2020 - 15:53:04: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/13/2020 - 15:53:04: [SM] Call stack trace:
L 08/13/2020 - 15:53:04: [SM]   [1] Line 12455, Unofficial Freak Fortress::OnPlayerHurt
L 08/13/2020 - 15:52:43: [SM] Exception reported: Invalid Handle 1f1a0c5d (error: 1)
L 08/13/2020 - 15:52:43: [SM] Blaming: disabled/freak_fortress_2.smx
L 08/13/2020 - 15:52:43: [SM] Call stack trace:
L 08/13/2020 - 15:52:43: [SM]   [0] ArrayList.Push
L 08/13/2020 - 15:52:43: [SM]   [1] Line 601, Unofficial Freak Fortress::FF2Protected.PushToTail
L 08/13/2020 - 15:52:43: [SM]   [2] Line 656, Unofficial Freak Fortress::FF2Protected.Request
L 08/13/2020 - 15:52:43: [SM]   [3] Line 15172, Unofficial Freak Fortress::GetArgumentI
L 08/13/2020 - 15:52:43: [SM]   [4] Line 15149, Unofficial Freak Fortress::GetAbilityArgument
L 08/13/2020 - 15:52:43: [SM]   [5] Line 17691, Unofficial Freak Fortress::Native_GetAbilityArgument
L 08/13/2020 - 15:52:43: [SM]   [7] FF2_GetAbilityArgument
L 08/13/2020 - 15:52:43: [SM]   [8] Line 563, C:\Games\tf2server\tf\addons\sourcemod\scripting\freaks\shadow93_bosses.sp::FF2_OnLoseLife
L 08/13/2020 - 15:52:43: [SM]   [10] Call_Finish
L 08/13/2020 - 15:52:43: [SM]   [11] Line 12439, Unofficial Freak Fortress::OnPlayerHurt
01Pollux commented 4 years ago

Patched the invalid handles, im unsure about those other errors

MAGNAT2645 commented 4 years ago

Recompiled but some abilities still work weird (dynamic_teleport doesn't have cooldown etc.) Maybe i should recompile subplugins too (like ff2_dynamic_defaults.ff2) ?

MAGNAT2645 commented 4 years ago

Found out that ff2_replaceprojectile.ff2 crashes the server on round start (due to Host_Error: Bad string: ? from PrecacheModel). https://crash.limetech.org/7w577r3lch6h изображение

Boss config:

    "ability14"
    {
        "name"          "replace_projectile"

        "arg1"          "tf_projectile_pipe" //name of the projectile to replace the model of
        "arg2"          "models/player/items/mvm_loot/all_class/mvm_flask_generic.mdl" //replacement model
        "arg3"          "2.0" //model scale

        "plugin_name"   "ff2_replaceprojectile"
    }
01Pollux commented 4 years ago

Yes... i know the problem is empty string, thats why i created the pull request and explained where the problem emit from. all i need is to know the actual line where it actually fails (UTIL_FindCharArg)

MAGNAT2645 commented 4 years ago

There's also TF2Attributes error (i'm not sure if this happens due to same empty string bug):

L 08/14/2020 - 11:50:51: [SM] Exception reported: Cowardly refusing to add invalid attribute index "0" to an item.
L 08/14/2020 - 11:50:51: [SM] Blaming: freaks/F2P_Plugin.ff2
L 08/14/2020 - 11:50:51: [SM] Call stack trace:
L 08/14/2020 - 11:50:51: [SM]   [0] TF2Items_SetAttribute
L 08/14/2020 - 11:50:51: [SM]   [1] Line 47, F:\M7's Server\steamapps\common\Team Fortress 2 Dedicated Server\tf\addons\sourcemod\scripting\F2P_Plugin.sp::SpawnWeapon
L 08/14/2020 - 11:50:51: [SM]   [2] Line 96, F:\M7's Server\steamapps\common\Team Fortress 2 Dedicated Server\tf\addons\sourcemod\scripting\F2P_Plugin.sp::lifelose_soldier
L 08/14/2020 - 11:50:51: [SM]   [3] Line 29, F:\M7's Server\steamapps\common\Team Fortress 2 Dedicated Server\tf\addons\sourcemod\scripting\F2P_Plugin.sp::FF2_OnAbility2
L 08/14/2020 - 11:50:51: [SM]   [4] Line 50, F:\M7's Server\steamapps\common\Team Fortress 2 Dedicated Server\tf\addons\sourcemod\scripting\include\freak_fortress_2_subplugin.inc::FF2_OnAbility
L 08/14/2020 - 11:50:51: [SM]   [6] Call_Finish
L 08/14/2020 - 11:50:51: [SM]   [7] Line 17174, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp::UseAbility
L 08/14/2020 - 11:50:51: [SM]   [8] Line 11503, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp::ActivateAbilitySlot
L 08/14/2020 - 11:50:51: [SM]   [9] Line 12443, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freak_fortress_2.sp::OnPlayerHurt

Also UTIL_FindCharArg needs some debugging to see what it is returning (false/true).

MAGNAT2645 commented 4 years ago

Also, why have you added UTIL_FindCharArg? What purpose? I suppose it is to format string like arg%i read value from ConfigMap or something?

EDIT: WAIT a second, why are there two FF2Data (one from include and one from source and they have same method names)? Nevermind, freak_fortress_2.inc is not included into source.

01Pollux commented 4 years ago

"UTIL_FindCharArg" is suppose to get boss handle (StringMap) and read cached ability. if it doesnt exist at all: tries to loop throught the config then register its "ability%i" so that KeyValues have easier time reading. if again didnt found, its going to set its key cache to NULL do that next time it knows that the loop already happened.

MAGNAT2645 commented 4 years ago 
L 08/18/2020 - 14:25:21: [SM] Exception reported: Entity -1 (-2145451798) is not a valid entity
L 08/18/2020 - 14:25:21: [SM] Blaming: freaks/ff2_dynamic_defaults.ff2
L 08/18/2020 - 14:25:21: [SM] Call stack trace:
L 08/18/2020 - 14:25:21: [SM]   [0] RemoveEntity
L 08/18/2020 - 14:25:21: [SM]   [1] Line 1450, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freaks\ff2_dynamic_defaults.sp::DSSG_RemoveSentry
L 08/18/2020 - 14:25:21: [SM]   [2] Line 1475, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freaks\ff2_dynamic_defaults.sp::DSSG_Tick
L 08/18/2020 - 14:25:21: [SM]   [3] Line 2705, C:\Home\TF2-Server-Files\tf\addons\sourcemod\scripting\freaks\ff2_dynamic_defaults.sp::OnGameFrame
MAGNAT2645 commented 4 years ago 
[freaks/shadow93_abilities.ff2] [SHADoW93 Minions] SCP-173 has an invalid  formula for minions, using default health!

SCP-173 doesn't have minions ability in my config...

Batfoxkid commented 3 years ago

I guess a check up to see if there's any more problems with FF2.

I can't actually live test

ImaginaryTraveller commented 3 years ago

kinda afarid to update with all these bugs.... wdym by u cant live test?