Baton34 / organize-search-engines

Automatically exported from code.google.com/p/organize-search-engines
Other
32 stars 4 forks source link

crash with newly added engines #28

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
when an engine is added, and the rdf is saved, reloaded, or a template is
rebuilt, Firefox crashes.

Original issue reported on code.google.com by maltekr...@gmail.com on 11 Oct 2007 at 4:26

GoogleCodeExporter commented 8 years ago
the bug's in _addMissingEnginesToRDF, line 214: 
container.AppendElement(current);

Original comment by maltekr...@gmail.com on 15 Oct 2007 at 7:43

GoogleCodeExporter commented 8 years ago
see e.g. this talkback report:
http://talkback-public.mozilla.org/search/start.jsp?search=2&type=iid&id=TB37095
068Q

Original comment by maltekr...@gmail.com on 18 Oct 2007 at 8:01

GoogleCodeExporter commented 8 years ago
well, actually it was this:
    while(hasMore) // only renumber once
      rootContainer.RemoveElement(elements.getNext(), !(elements.hasMoreElements());

callung begin/endUpdateBatch before and after it fixed the problem and is much
cleaner anyways :)

Original comment by maltekr...@gmail.com on 18 Oct 2007 at 8:18