Baton34 / organize-search-engines

Automatically exported from code.google.com/p/organize-search-engines
Other
32 stars 4 forks source link

Invoke of an "Open All in Tabs" engine should not always close the engine popup #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I have written an userChrome.js script to archive:
1. Left click on an engine menuitem would change to the engine and do search;
2. Ctrl + Left click on an engine menuitem would do search and keep the
menu open

But with OSE "Open All in Tabs" items, OSE always closes the engine popup
immediately. This happens with both OSE 1.4 and OSE 1.5 RC1. Would you
kindly to provide a fix? I could send you my script if needed.

Original issue reported on code.google.com by ithincu@gmail.com on 28 Mar 2009 at 4:57

GoogleCodeExporter commented 8 years ago
Accepting.

Under the hood when choosing "Open All in Tabs", OSE adds a fake engine to the 
search
service and selects it. The search service notifies the search bar of the new 
engine.
The code in the search bar hides the list with the search engines 'just in 
case'. It
should probably only do so when it's really neccessary. The hard thing is to 
know,
when it's really neccessary...

So I can actually confirm that an eventual fix really fixes your problem, 
having the
script around would be quite helpful, so please attach it here or send it to me
(firefox at maltekraus de).

Original comment by maltekr...@gmail.com on 12 Jun 2009 at 7:44

GoogleCodeExporter commented 8 years ago
I think I just commited a fix for this to SVN. It's untested, however.

Original comment by maltekr...@gmail.com on 14 Jun 2009 at 6:53

GoogleCodeExporter commented 8 years ago

Original comment by maltekr...@gmail.com on 14 Jun 2009 at 6:55