BattMoTeam / BattMo-gui

BattMo GUI development
MIT License
4 stars 0 forks source link

Resolution of +/- buttons #6

Closed jsimonclark closed 1 year ago

jsimonclark commented 1 year ago

The +/- buttons for the parameters all move in increments of 0.01. Can we adjust this to be more reflective of the order of magnitude of the parameters? For example, maybe temperature goes in order of 5 degrees, while electrode thickness goes in increments of 5e-6 m?

oscarbolzinger commented 1 year ago

The increment is adjustable, we just have to define it. One easy solution for that could be fixing the increment as something like 5% of the value, or maybe the closest multiple of 10 to 5% of the value... This would avoid creating a new parameter "increment" for every parameter.

what do you think?

jsimonclark commented 1 year ago

Good idea. We should try to round the increments to something reasonable to avoid getting some odd increments like 14.91 (5% of 298.15) - is that what you mean with "the closest multiple"?

oscarbolzinger commented 1 year ago

yes that's what I mean: if it's 14.91 then the closest multiple of 10 would be 10. We could also choose the closest and bigger one which would be 20 in this case.

oscarbolzinger commented 1 year ago

I tried something, check it out on the branch oscar_fix_issues