search

BattModels / ElectrochemicalKinetics.jl

Electrochemical reaction rate modeling and nonequilibrium phase maps (via AD)
MIT License
22 stars 9 forks source link

adding benchmarks #37

Closed rkurchin closed 2 years ago

rkurchin commented 2 years ago

Still a few more to write, but the basic skeleton is there...

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4b07b6e). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   46.40%           
=========================================
  Files             ?        8           
  Lines             ?      306           
  Branches          ?        0           
=========================================
  Hits              ?      142           
  Misses            ?      164           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b07b6e...110849d. Read the comment docs.

DhairyaLGandhi commented 2 years ago

Generally, we should move things inside functions as much as possible. This is mostly to avoid global variables. If we want to define the models globally, we can make use of the setup kwarg in @benchmarkable so that the variables remain local to the functions as they are being targeted.

Would it make sense to add a benchmarking environment that devs EK and has the rest of the packages?