BattModels / ElectrochemicalKinetics.jl

Electrochemical reaction rate modeling and nonequilibrium phase maps (via AD)
MIT License
21 stars 8 forks source link

More robust handling of multiple solutions for `overpotential` #52

Open rkurchin opened 2 years ago

rkurchin commented 2 years ago

Currently, there can be some wacky behavior when there are multiple valid solutions for overpotential (e.g. before and after inverted region in a Marcus model, or around nonmonotonicities in MHC+DOS models). It would be good to have smarter ways to detect that....in the Marcus case, we know analytically when the inverted region starts, so could try to constrain search to be before it. For MHC+DOS it's a bit trickier, might need to add some stochasticity to the optimizer to find the best minimum and also balance against wanting the lowest-voltage good solution...