Installation documentation

[i64]

Hi authors, I am reviewing the code from https://github.com/openjournals/joss-reviews/issues/6881.

In installation cd DTWC++ is wrong it should be cd dtw-cpp

running is itself the installation, and overview, installation, running should be in order. Also -j32 should not be assumed where you could use this command in in linux to determine number of processors.

cmake --build . -j$(( $(nproc) * 2 -1))

[ElektrikAkar]

Hi,

Thank you very much for your comment! We have fully updated the installation documentation https://github.com/Battery-Intelligence-Lab/dtw-cpp/pull/20.

• We corrected DTWC++ to dtw-cpp as you suggested.
• Regarding the build process, we decided to retain -j4 for two reasons:
  i) It is clearer and more readable than -j$(( $(nproc) * 2 - 1)).
  ii) Different operating systems may require different commands to check the number of processors. For example, on Windows, we were able to display the number of processors using the echo %NUMBER_OF_PROCESSORS% command; however, it did not support mathematical operations like 2* %NUMBER_OF_PROCESSORS% - 1. Therefore, we prefer to keep the command as -j4. However, we have added an explanation to clarify the reasoning behind the number 4 and included -j$(( $(nproc) * 2 - 1)) in the Linux section. We also reduced the number from -j32 to -j4 to better accommodate users with lower-spec systems.

[i64]

Hi @ElektrikAkar,

I checked the commit. LGTM!